1294656 - Seek to nearest keyframe when resuming videos with no audio - no audio track

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Tzuhao Kuo [:kaku]]

A sub-bug of Bug 1282012.

While resuming from background, apply FastSeek to video files without audio track.

Comment 1

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1294656 - apply FastSeek to video files without audio track;

Review commit: https://reviewboard.mozilla.org/r/71164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71164/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8780459 [details]
Bug 1294656 - apply FastSeek to video files without audio track;

https://reviewboard.mozilla.org/r/71164/#review68676

::: dom/media/MediaDecoderStateMachine.cpp:1373
(Diff revision 1)
>      }
>  
>      // Start video-only seek to the current time...
>      SeekJob seekJob;
> +
> +    if (!HasAudio()) {

You can do:

SeekTarget::Type type = HasAudio() ? SeekTarget::Type::Accurate : SeekTarget::Type::PrevSyncPoint;

seekJob.mTarget = SeekTarget(..., type, ...);

so you have less redundant code.

Comment 3

[Tzuhao Kuo [:kaku]]

Comment on attachment 8780459 [details]
Bug 1294656 - apply FastSeek to video files without audio track;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71164/diff/1-2/

Comment 4

[Tzuhao Kuo [:kaku]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f0cb0e5aa49
The problems in Android platform seems not related to this bug.

Thanks for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5dc69346897
apply FastSeek to video files without audio track; r=jwwang

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a5dc69346897