1294737 - Recognize whole placeables in format %(something)_

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Pontoon recognizes only the word in brackets as placeable. If you check the URL, instead of "%(passwordChangeLink)s", only %("passwordChangeLink")s is being matched. I think the same would be for %(foo)d, if it appears in a string.

Comment 1

[Matjaz Horvat [:mathjazz]]

Thanks for reporting, Michal!

Would you be willing to provide a patch if I mentor you?

Comment 2

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Yes. :) I have refreshed my laptop recently, but started installing local Pontoon right now.

Comment 3

[Matjaz Horvat [:mathjazz]]

This is where we keep the placeables code:
https://github.com/mozilla/pontoon/blob/master/pontoon/base/utils.py#L44

Comment 4

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

How are these placeables exactly called? I cannot find, where do they originally come from.

Comment 5

[Matjaz Horvat [:mathjazz]]

In pontoon.base.models.py:Entity.map_entities() a list of entities is generated to be sent to the translate view. Entity.marked property is used for storing the source string representation with placeables markup. And the marked property is basically pontoon.base.utils.mark_placeables(Entity.string).

Let me know if that helps. I'm also available in #pontoon.

Comment 6

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Attachment: GitHub PR

Comment 7

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Created PR on GitHub.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/94ae3c976f220a463ace4aa56fc5188dd531d61b
Fix bug 1294737: Recognize string format named placeables (#452)