[FlyWeb] NS_ERROR_FAILURE on 'Nightly' builds for Windows and Linux

RESOLVED FIXED in Firefox 51

Status

()

Core
Networking
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: justindarc, Assigned: djvj)

Tracking

(Blocks: 1 bug)

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [necko-would-take])

Attachments

(2 attachments)

(Reporter)

Description

a year ago
The following error is logged to the console when running an official "Nightly" build for Windows or Linux:

Error: [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "<unknown>"  data: no]

It seems as though the mDNS fallback implementation is not being included in the builds even though this problem does not happen when doing a local build of m-c.
(Reporter)

Updated

a year ago
Assignee: nobody → kvijayan
Blocks: 1228662
Whiteboard: [necko-would-take]
(Assignee)

Comment 1

a year ago
Created attachment 8780607 [details] [diff] [review]
fix-nightly-package-components.patch

Test patch.  Waiting on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9aaf49097741
(Assignee)

Comment 2

a year ago
Comment on attachment 8780607 [details] [diff] [review]
fix-nightly-package-components.patch

Yeah, this fixes the issue.  Change is literally adding files to desktop distribution.  I would usually send this to Jonas for review, but Jonas isn't reviewing things anymore.  So I'm r+-ing it myself.
Attachment #8780607 - Flags: review+

Comment 3

a year ago
Pushed by kvijayan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f67dc612d5a6
Add nsDNSServiceDiscovery fallback implementation to desktop package manifest. r=djvj

Comment 4

a year ago
Pushed by kvijayan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee721407a44a
Backout f67dc612d5a6 for OSX build bustage. r=backout
(Assignee)

Comment 5

a year ago
Created attachment 8780714 [details] [diff] [review]
fix-nightly-package-components.patch

Previous bustage was due to including un-bundled fallback impl files in the OSX package manifest.  New try looks green on build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a8b244aff24
Attachment #8780714 - Flags: review+

Comment 6

a year ago
Pushed by kvijayan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fb68854b93a
Add nsDNSServiceDiscovery fallback implementation to desktop package manifest. r=djvj

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2fb68854b93a
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Updated

a year ago
Depends on: 1295870
You need to log in before you can comment on or make changes to this bug.