Support running web-platform-tests from interactive loaner

RESOLVED FIXED in Firefox 56

Status

Testing
web-platform-tests
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: ahal, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

Version 3
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
We should add a test package command for running web-platform-tests.

Taking a quick look at testing/web-platform/mach_commands.py, this might be a bit more involved than the other harnesses because there is a lot of MozbuildObject dependent logic in the mach command (with other harnesses, the mach_commands.py was refactored into the harness, and relatively empty).

My general approach has been to create a new mach_test_package_commands.py file to keep the two mach environments separate. However there is still a lot of code that should be shared between these two mach commands. Ideally this would be refactored into the test harness, but I'm not sure if that's possible given wpt's upstream repo.
(Reporter)

Updated

a year ago
Duplicate of this bug: 1297044
getting a 1-click loaner and using option #2, yields a prompt with stuff downloaded, but unlike mochitests, there is no venv setup and activated.
(Reporter)

Updated

a year ago
Duplicate of this bug: 1308511
(Reporter)

Updated

a year ago
Depends on: 1308513
Summary: Add mach test package command for running web-platform-tests → Support running web-platform-tests from interactive loaner
(Reporter)

Comment 4

a year ago
WPT has been modified to run from the srcdir instead of the test package. So the steps to get this supported will differ slightly from other harnesses. I think ideally we modify the existing mach command to not depend on an objdir, and just re-use that from the loaner.
(Reporter)

Comment 5

a year ago
More context:
<ahal> jgraham: in case you're very anxious to get this moving, the next step will be to detect if there is a srcdir and add the 'mach' binary to $PATH there instead of this: https://dxr.mozilla.org/mozilla-central/source/taskcluster/scripts/tester/run-wizard#53
<ahal> and then after that, it is just a matter of modifying the mach command to provide intelligent defaults (i.e automatically find the firefox binary that mozharness downloaded, etc)
a recent attempt at this:
elect one of the above options: 2
Timed out after 30 seconds waiting for the 'run-mozharness' binary
run-mozharness --no-run-tests
Traceback (most recent call last):
  File "./run-wizard", line 170, in <module>
    sys.exit(wizard())
  File "./run-wizard", line 163, in wizard
    ret = func()
  File "./run-wizard", line 47, in setup
    status = call(['run-mozharness', '--no-run-tests'])
  File "./run-wizard", line 20, in call
    return subprocess.call(cmd, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 523, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/usr/lib/python2.7/subprocess.py", line 711, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1343, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
root@taskcluster-worker:~# 

not sure if we can get to this sometime in the near future.
Blocks: 1348833
Comment hidden (mozreview-request)
(Reporter)

Comment 8

4 months ago
mozreview-review
Comment on attachment 8879645 [details]
Bug 1294820 - Add support for running wpt from one-click loaner mach environment,

https://reviewboard.mozilla.org/r/151012/#review155800

Thanks for tackling this! Should we handle the wizard issue in a follow-up?
Attachment #8879645 - Flags: review?(ahalberstadt) → review+

Comment 9

4 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/21c963bcc2ce
Add support for running wpt from one-click loaner mach environment, r=ahal

Comment 10

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/21c963bcc2ce
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.