1294841 - Focus ring appears around the viewport

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Undesired Focus Ring

This seems tied to a relatively recent CSS change elsewhere in DevTools.  The viewport now gets a focus outline around it if you click anywhere inside the viewport.  Also, the blue selection markers appear at the bottom left and right corner of the viewport.

Something like the following CSS change should fix it:

.browser {
  display: block;
  border: 0;
  -moz-user-select: none;
}

.browser:-moz-focusring {
  outline: none;
}

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1294841 - Remove selection and focus ring from RDM browser.

Review commit: https://reviewboard.mozilla.org/r/72146/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72146/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:bgrins, this seems like it appeared recently due to some surrounding DevTools accessibility CSS changes, and I've noticed you reviewing some of those, so you seemed like a good choice.

To check it out in new RDM, set devtools.responsive.html.enabled to true and restart Firefox before opening RDM.

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8781819 [details]
Bug 1294841 - Remove selection and focus ring from RDM browser.

https://reviewboard.mozilla.org/r/72146/#review70022

This seems fine

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30da32629a3c
Remove selection and focus ring from RDM browser. r=bgrins

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/30da32629a3c

Comment 6

[Sayed [:LiquidO2]]

I have reproduced this bug using the instruction from comment #2 with Nightly 51.0a1 (2016-08-13) on Elementary OS 64bit. 

This bug's fix is now verified on Latest Nightly 51.0a1

build id 	20160901030202
user agent	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160831]