1294887 - Middle clicking search results does not open a new tab

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[xenotoad]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160812030200

Steps to reproduce:

Enter a few terms into the search box in the upper-right and middle-click one of the results.


Actual results:

The search box disappeared for a little bit when I released the middle-click.


Expected results:

The search result should be opened in a new tab and the search box should not disappear.

Comment 1

[Florian Quèze [:florian]]

I think we could use some help here to triage, eg. to answer the following questions:
- can someone else reproduce?
- Is this Linux-specific, or on all platforms?
- Is it a regression or has it always been this way?

Comment 2

[Liviu Cirdei]

Hi, 

I reproduce this on Windows 10, so it's not Linux only and it is a regression. 

Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=46045ec8a4aa09a341b7209170089ade3c27c1a5&tochange=555caa0082c342c60830261ecba4c4068122207e

Regressed by bug 1180944 (MozReview-Commit-ID: A9YXB32L7MN).

Comment 3

[Gerry Chang [:gchang]]

Hi :adw,
Since you fixed bug 1180944, could you help to take a look at this one?

Comment 4

[Drew Willcoxon :adw]

Yep, I'll look at this one along with the other regressions.

Comment 5

[Justin Dolske [:Dolske]]

Possible dupe / same cause as bug 1296366?

Comment 6

[Drew Willcoxon :adw]

Attachment: Bug 1294887 - Middle clicking search results does not open a new tab.

Review commit: https://reviewboard.mozilla.org/r/86208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/86208/

Comment 7

[Drew Willcoxon :adw]

Thanks for filing this.  As far as I can tell, the popup always closed and then quickly reopened, so I think this is only really about the tab not properly loading in the background.

Florian, I removed the "tab-background" option for `where` in the urlbar one-offs bug since it was kind of non-standard (i.e., something not returned by whereToOpenLink IIRC), in favor of the more-standard "tab" plus params.inBackground.  This is one place in urlbarBindings that was still using tab-background.  I searched dxr for tab-background and there are no more instances.

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8801457 [details]
Bug 1294887 - Middle clicking search results does not open a new tab.

https://reviewboard.mozilla.org/r/86208/#review85582

The patch looks reasonable. It's disappointing this regression wasn't caught by a test.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/545b89141c83
Middle clicking search results does not open a new tab. r=florian

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/545b89141c83

Comment 11

[Gerry Chang [:gchang]]

Hi :adw,
Can you help create a uplift request for 51 aurora?

Comment 12

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 51.0a1 (2016-08-12) on Windows 7 , 64 Bit !

This bug's fix is verified with latest Nightly 

Build ID    : 20161019030208
User Agent  : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
[bugday-20161019]

Comment 13

[Drew Willcoxon :adw]

Attachment: Aurora 51 patch

Approval Request Comment
[Feature/regressing bug #]: One-off searches in the urlbar, bug 1180944
[User impact if declined]: Middle-clicking search results will not open them in a new tab
[Describe test coverage new/current, TreeHerder]: Manual testing
[Risks and why]: Low risk, small patch
[String/UUID change made/needed]: None

Comment 14

[Gerry Chang [:gchang]]

Comment on attachment 8802645 [details] [diff] [review]
Aurora 51 patch

Fix a regression related to urlbar. Take it in 51 aurora.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e3af706f66bc

Comment 16

[Liviu Cirdei]

For Nightly 52 the fix is also verified on Mac 10.11 and Ubuntu 16.04.

For Aurora 51 (Build ID 20161021004016) the fix is verified on Windows 10, Mac 10.11 and Ubuntu 16.04.