1294937 - The context menu does not appear when right-click on the inspector-searchbox

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[magicp]

Attachment: inspector-searchbox-contextmenu.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160812030200

Steps to reproduce:

1. Start Nightly
2. Open DevTools > Inspector
3. Right-click on inspector-searchbox


Actual results:

The context menu does not appear when right-click on the inspector-searchbox.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c9bbdb627b7804fee47aa6a6708647e6e589d09c&tochange=3269dd1a824d1b42cb021d1fb6858885179940b0




Expected results:

The context menu works on the inspector-searchbox.

Comment 1

[[e-mail]]

Attachment: Bug 1294937 - The context menu does not appear when right-click on the inspector-searchbox;

Review commit: https://reviewboard.mozilla.org/r/71484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71484/

Comment 2

[[e-mail]]

Comment on attachment 8780970 [details]
Bug 1294937 - The context menu does not appear when right-click on the inspector-searchbox;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71484/diff/1-2/

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8780970 [details]
Bug 1294937 - The context menu does not appear when right-click on the inspector-searchbox;

https://reviewboard.mozilla.org/r/71484/#review69246

Changes look good. Please add an unit test so we don't run into this regression again.

Good examples are:
http://searchfox.org/mozilla-central/source/devtools/client/inspector/rules/test/browser_rules_search-filter_context-menu.js
http://searchfox.org/mozilla-central/source/devtools/client/inspector/computed/test/browser_computed_search-filter_context-menu.js

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8780970 [details]
Bug 1294937 - The context menu does not appear when right-click on the inspector-searchbox;

https://reviewboard.mozilla.org/r/71484/#review69248

Comment 5

[[e-mail]]

Comment on attachment 8780970 [details]
Bug 1294937 - The context menu does not appear when right-click on the inspector-searchbox;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71484/diff/2-3/

Comment 6

[[e-mail]]

Thanks for provide good examples! I modified them and test seems works well

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8780970 [details]
Bug 1294937 - The context menu does not appear when right-click on the inspector-searchbox;

https://reviewboard.mozilla.org/r/71484/#review69502

::: devtools/client/inspector/test/browser_inspector_search-filter_context-menu.js:6
(Diff revision 3)
> +/* vim: set ft=javascript ts=2 et sw=2 tw=80: */
> +/* Any copyright is dedicated to the Public Domain.
> +   http://creativecommons.org/publicdomain/zero/1.0/ */
> +"use strict";
> +
> +// Test main search filter context menu works properly.

Should clarify that this is testing the inspector's markup view search filter context menu

::: devtools/client/inspector/test/browser_inspector_search-filter_context-menu.js:10
(Diff revision 3)
> +
> +// Test main search filter context menu works properly.
> +
> +const TEST_INPUT = "h1";
> +const TEST_URI = "data:text/html;charset=utf-8," +
> +  encodeURIComponent("<h1>test filter context menu</h1>");

I usually prefer seeing:
yield addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));

That way we can keep the HTML separate from the data:text/html protocol string.

::: devtools/client/inspector/test/browser_inspector_search-filter_context-menu.js:13
(Diff revision 3)
> +const TEST_INPUT = "h1";
> +const TEST_URI = "data:text/html;charset=utf-8," +
> +  encodeURIComponent("<h1>test filter context menu</h1>");
> +
> +add_task(function* () {
> +

Remove empty line

::: devtools/client/inspector/test/browser_inspector_search-filter_context-menu.js:14
(Diff revision 3)
> +const TEST_URI = "data:text/html;charset=utf-8," +
> +  encodeURIComponent("<h1>test filter context menu</h1>");
> +
> +add_task(function* () {
> +
> +  let {tab, toolbox, inspector} = yield openInspectorForURL(TEST_URI);

Remove 'tab' since it is not used.

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8780970 [details]
Bug 1294937 - The context menu does not appear when right-click on the inspector-searchbox;

https://reviewboard.mozilla.org/r/71484/#review69506

Comment 9

[[e-mail]]

Comment on attachment 8780970 [details]
Bug 1294937 - The context menu does not appear when right-click on the inspector-searchbox;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71484/diff/3-4/

Comment 10

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8780970 [details]
Bug 1294937 - The context menu does not appear when right-click on the inspector-searchbox;

https://reviewboard.mozilla.org/r/71484/#review69716

::: devtools/client/inspector/test/browser_inspector_search-filter_context-menu.js:15
(Diff revisions 3 - 4)
>  
>  add_task(function* () {
> -
> -  let {tab, toolbox, inspector} = yield openInspectorForURL(TEST_URI);
> +  yield addTab("data:text/html;charset=utf-8," + encodeURIComponent(TEST_URI));
> +  let {toolbox, inspector} = yield openInspector();
>    let {searchBox} = inspector;
> -  yield selectNode("h1", inspector);
> +  yield selectNode(TEST_INPUT, inspector);

I think it will be better to keep this as "h1".

Comment 11

[[e-mail]]

Comment on attachment 8780970 [details]
Bug 1294937 - The context menu does not appear when right-click on the inspector-searchbox;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/71484/diff/4-5/

Comment 12

[[e-mail]]

issue addressed, change commit message to ; r=gl

thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/165ca35b1586
The context menu does not appear when right-click on the inspector-searchbox. r=gl

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/165ca35b1586

Comment 15

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this bug using Fx 51.0a1, build ID: 20160812030200, on Windows 10 x64.
I can confirm the bug is fixed, I verified using Fx 51.0a1 build ID: 20160819030226, on Windows 10 x64, Ubuntu 14.04 LTS and Mac OS X 10.10.