1294940 - Add ConstUTF8CharsZ class for "const char *" typed UTF8.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

Separated from bug 987069.

I want to use ConstUTF8CharsZ class also in bug 1283710 and depending bugs.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Part 0.1: Capitalize template parameter "action" of InflateUTF8StringToBuffer.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Part 0.2: Make InflateUTF8StringHelper template function instead of passing count action function.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Part 1: Add ConstUTF8CharsZ class for const UTF8 string.

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Part 2: Add validation for ConstUTF8CharsZ.

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Part 3: Add ConstUTF8CharsZ variant for UTF8CharsToNewTwoByteCharsZ and LossyUTF8CharsToNewTwoByteCharsZ.

Comment 6

[Tooru Fujisawa [:arai]]

Comment on attachment 8781238 [details] [diff] [review]
Part 1: Add ConstUTF8CharsZ class for const UTF8 string.

These patches are almost identical to the patch in original bug tho,
I'd like to ask review again about length parameter and validation part.

Comment 7

[Tooru Fujisawa [:arai]]

I meant, those are only the difference between the original patch.
others are same or trivial change.

Comment 8

[Jeff Walden [:Waldo]]

Comment on attachment 8781238 [details] [diff] [review]
Part 1: Add ConstUTF8CharsZ class for const UTF8 string.

Review of attachment 8781238 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/public/CharacterEncoding.h
@@ +109,5 @@
>      char* c_str() { return reinterpret_cast<char*>(get()); }
>  };
>  
>  /*
> + * A wrapper for a "const char *" that is encoded using UTF-8.

const char*

Stars by types are wrong throughout this, actually.

Comment 9

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c1c4f1f646dc8a56c813131206e3b4e32ea4f5d4
Bug 1294940 - Part 0.1: Capitalize template parameter "action" of InflateUTF8StringToBuffer. r=jwalden

https://hg.mozilla.org/integration/mozilla-inbound/rev/27bfa4989cc987bad6d7ddafb07ee6d3550fcf3d
Bug 1294940 - Part 0.2: Make InflateUTF8StringHelper template function instead of passing count action function. r=jwalden

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb091f358c2795aaa3e4cbe2b413edd283dc2c33
Bug 1294940 - Part 1: Add ConstUTF8CharsZ class for const UTF8 string. r=jwalden

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e0129fc331893b14103f1cb2f8799a1cf2b6772
Bug 1294940 - Part 2: Add validation for ConstUTF8CharsZ. r=jwalden

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa74aca78adde46c2626a8b5fa628ea22257e3d4
Bug 1294940 - Part 3: Add ConstUTF8CharsZ variant for UTF8CharsToNewTwoByteCharsZ and LossyUTF8CharsToNewTwoByteCharsZ. r=jwalden

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c1c4f1f646dc
https://hg.mozilla.org/mozilla-central/rev/27bfa4989cc9
https://hg.mozilla.org/mozilla-central/rev/bb091f358c27
https://hg.mozilla.org/mozilla-central/rev/3e0129fc3318
https://hg.mozilla.org/mozilla-central/rev/aa74aca78add