Closed Bug 1295057 Opened 9 years ago Closed 5 months ago

Underlying eyedropper screenshot should be updated when the page is resized (including enabling RDM)

Categories

(DevTools :: Responsive Design Mode, defect, P2)

Product:
DevTools
Component:
Responsive Design Mode
Type:
defect

Tracking

(firefox48 unaffected, firefox49 unaffected, firefox50 wontfix, firefox51 wontfix, firefox52 wontfix, firefox-esr115 wontfix, firefox-esr128 wontfix, firefox-esr140 wontfix, firefox140 wontfix, firefox141 fixed)

Status:
RESOLVED FIXED
Milestone:
141 Branch
Tracking Flags:
Tracking Status
firefox48 --- unaffected
firefox49 --- unaffected
firefox50 --- wontfix
firefox51 --- wontfix
firefox52 --- wontfix
firefox-esr115 --- wontfix
firefox-esr128 --- wontfix
firefox-esr140 --- wontfix
firefox140 --- wontfix
firefox141 --- fixed

People

(Reporter: magicp.jp, Assigned: hbenl)

References

(Blocks 2 open bugs)

Details

(Keywords: regression)

Attachments

(2 files)

magnifying-glass-of-eyedropper-is-gone-when-running-responsibe-design-mode.mp4
426.96 KB, video/mp4
Details
Bug 1295057 - [devtools] Update the eyedropper screenshot on resize. r=#devtools-reviewers
48 bytes, text/x-phabricator-request
Details | Review
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 Build ID: 20160814030203 Steps to reproduce: 1. Start Nightly 2. Open DevTools > Inspector 3. Run Eyedropper 4. Enable Responsive Design Mode Actual results: The magnify glass of eyedropper is gone when running Responsive Design Mode. Expected results: The magnify glass of eyedropper works with Responsive Design Mode.
Has STR: --- → yes
status-firefox48: --- → unaffected
status-firefox49: --- → unaffected
status-firefox50: --- → affected
status-firefox51: --- → affected
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
See Also: → 1295607
Flagging this as an important regression. I'm going to try to fix this soon.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Priority: -- → P2
This happens in both the current RDM (Responsive Design Mode), and the new one (the one being developed bow behind flag devtools.responsive.html.enabled). This is most probably an issue with doing swapFrameLoader, which I think both RDM implementations do.
(In reply to Patrick Brosset <:pbro> from comment #3) > This happens in both the current RDM (Responsive Design Mode), and the new > one (the one being developed bow behind flag > devtools.responsive.html.enabled). This is most probably an issue with doing > swapFrameLoader, which I think both RDM implementations do. Only the new RDM uses frame loader / docshell swapping. The old RDM UI has elements surrounding the xul:browser that are hidden during regular browsing and then shown when opened, so nothing is swapped with the old RDM.
status-firefox52: --- → affected
Unassigned myself as I'm not working on this.
Assignee: pbrosset → nobody
Status: ASSIGNED → NEW
Mass wontfix for bugs affecting firefox 52.
status-firefox52: affected → wontfix
Product: Firefox → DevTools

Changing component so we can track this along with other RDM bugs.

Component: Inspector → Responsive Design Mode
Severity: normal → S3
Summary: The magnify glass of eyedropper is gone when running Responsive Design Mode → Underlying eyedropper screenshot should be updated when the page is resized (including enabling RDM)
Assignee: nobody → hbenl
Status: NEW → ASSIGNED
Pushed by hbenl@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/938c6b981f2d https://hg.mozilla.org/integration/autoland/rev/ced0640c8fcc [devtools] Update the eyedropper screenshot on resize. r=devtools-reviewers,ochameau
Regressions: 1971695
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d6f0e15572da https://hg.mozilla.org/integration/autoland/rev/b38e43d5c713 Revert "Bug 1295057 - [devtools] Update the eyedropper screenshot on resize. r=devtools-reviewers,ochameau" for causing dt failures @browser_eyedropper_update.js.

Backed out for causing dt failures @browser_eyedropper_update.js.

Flags: needinfo?(hbenl)
Pushed by hbenl@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6699f01fb3d1 https://hg.mozilla.org/integration/autoland/rev/fcd2f6bc8f17 [devtools] Update the eyedropper screenshot on resize. r=devtools-reviewers,ochameau
Flags: needinfo?(hbenl)

https://hg.mozilla.org/mozilla-central/rev/fcd2f6bc8f17

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox141: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
QA Whiteboard: [qa-triage-done-c142/b141]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: