1295061 - [WebGL2] Enable conformance tests for Windows 8

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Daosheng Mu[:daoshengmu]]

Remove WEBGL2_SKIP_IF_CONDITION = (os == 'win' && os_version == '6.2')
and rebuild mochitest files.

Comment 1

[Daosheng Mu[:daoshengmu]]

After Bug 1290333 land, we can start to enable WebGL 2 in Windows 8 try servers.

Comment 2

[Daosheng Mu[:daoshengmu]]

Try looks good when I use fail-if at
test_2_conformance__glsl__constructors__glsl-construct-bvec2.html
test_2_conformance__glsl__constructors__glsl-construct-bvec3.html
test_2_conformance__glsl__constructors__glsl-construct-bvec4.html
test_2_conformance__glsl__constructors__glsl-construct-ivec2.html
test_2_conformance__glsl__constructors__glsl-construct-ivec3.html
test_2_conformance__glsl__constructors__glsl-construct-ivec4.html

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ecf356567b5

Comment 3

[Daosheng Mu[:daoshengmu]]

Adding other fail-if for
test_2_conformance__glsl__constructors__glsl-construct-vec-mat-corner-cases.html
test_2_conformance__glsl__constructors__glsl-construct-vec2.html
test_2_conformance__glsl__constructors__glsl-construct-vec3.html
test_2_conformance__glsl__constructors__glsl-construct-vec4.html

I believe this is because try servers use old driver version like our Windows 7 cases. I have confirmed it could be passed after I update NV driver to 2016.7 version in my loaner. 

And I think using fail-if is better that using skip-if. Because I imagine one day we will update our drivers, and we can aware this tests have already can be passed easily.

Try looks good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdd899a1cf97

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1295061 - Enable WebGL 2 conformance tests for Windows 8;

Review commit: https://reviewboard.mozilla.org/r/73186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73186/

Comment 5

[Ethan Lin[:ethlin]]

Comment on attachment 8783375 [details]
Bug 1295061 - Enable WebGL 2 conformance tests for Windows 8;

https://reviewboard.mozilla.org/r/73184/#review70950

Comment 6

[Ethan Lin[:ethlin]]

Comment on attachment 8783375 [details]
Bug 1295061 - Enable WebGL 2 conformance tests for Windows 8;

https://reviewboard.mozilla.org/r/73186/#review70952

Great!

Comment 7

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8783375 [details]
Bug 1295061 - Enable WebGL 2 conformance tests for Windows 8;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73186/diff/1-2/

Comment 8

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8783375 [details]
Bug 1295061 - Enable WebGL 2 conformance tests for Windows 8;

https://reviewboard.mozilla.org/r/73186/#review71562

Comment 9

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8783375 [details]
Bug 1295061 - Enable WebGL 2 conformance tests for Windows 8;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73186/diff/2-3/

Comment 10

[Daosheng Mu[:daoshengmu]]

In this update, I skip generated/test_2_conformance__canvas__drawingbuffer-static-canvas-test.html for needing more time to investigate and remove fail-if in generated/test_2_conformance__canvas__rapid-resizing.html because Win 8 can be pass in that test.

Comment 11

[Daosheng Mu[:daoshengmu]]

Try looks good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed94dfd70415.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a63a118b8b9
Enable WebGL 2 conformance tests for Windows 8; r=ethlin,jgilbert

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5a63a118b8b9