Closed Bug 1295081 Opened 8 years ago Closed 8 years ago

Fix inspector-searchinput-clear display behavior

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox50 unaffected, firefox51 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 51
Iteration:
51.2 - Aug 29
Tracking Flags:
Tracking Status
firefox50 --- unaffected
firefox51 --- verified

People

(Reporter: magicp.jp, Assigned: gasolin)

References

Details

(Whiteboard: [reserve-html])

Attachments

(2 files)

inspector-searchinput-clear-display-behavior-50-vs-51.mp4
361.64 KB, video/mp4
Details
Bug 1295081 - Fix inspector-searchinput-clear display behavior;
58 bytes, text/x-review-board-request
gl
: review+
Details 
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160814030203

Steps to reproduce:

1. Start Nightly
2. Open DevTools > Inspector
3. Type "d" in inspector-searchbox
4. Enter [Back space] key
5. Repeat step 3 to 4 (Check inspector-searchinput-clear display timing)


Actual results:

inspector-searchinput-clear is invisible in step 3. And it is displayed in step 4.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c9bbdb627b7804fee47aa6a6708647e6e589d09c&tochange=3269dd1a824d1b42cb021d1fb6858885179940b0


Expected results:

inspector-searchinput-clear should be displayed in step 3. And it will be invisible in step 4.
Blocks: 1265759
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox50: --- → unaffected
status-firefox51: --- → affected
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Blocks: devtools-html-2
Flags: qe-verify?
Whiteboard: [devtools-html] [triage]
Flags: qe-verify? → qe-verify+
Priority: -- → P3
QA Contact: cristian.comorasu
Whiteboard: [devtools-html] [triage] → [reserve-html]
@Fred, this is related to Bug 1265759, can you please take a look?

Thanks!

Honza
Flags: needinfo?(gasolin)
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Flags: needinfo?(gasolin)
fixed issue and add related test case
Comment on attachment 8781860 [details]
Bug 1295081 - Fix inspector-searchinput-clear display behavior;

https://reviewboard.mozilla.org/r/72194/#review70192

::: devtools/client/inspector/test/browser_inspector_search-clear.js:33
(Diff revision 2)
> +  let {inspector} = yield openInspectorForURL(TEST_URI);
> +  let {searchBox, searchClearButton} = inspector;
> +
> +  yield focusSearchBoxUsingShortcut(inspector.panelWin);
> +
> +  info("type d and the clear button will be shown");

Capitalize the first word in the info() - 'Type'

::: devtools/client/inspector/test/browser_inspector_search-clear.js:43
(Diff revision 2)
> +
> +  info("Waiting for search query to complete and getting the suggestions");
> +  yield inspector.searchSuggestions._lastQuery;
> +
> +  ok(!searchClearButton.hidden,
> +    "the clear button is shown when some word is in searchBox");

Capitalize the first word in the ok message.

::: devtools/client/inspector/test/browser_inspector_search-clear.js:51
(Diff revision 2)
> +  yield command;
> +
> +  info("Waiting for search query to complete and getting the suggestions");
> +  yield inspector.searchSuggestions._lastQuery;
> +
> +  ok(searchClearButton.hidden, "the clear button is hidden when no word is in searchBox");

Capitalize the ok message
Comment on attachment 8781860 [details]
Bug 1295081 - Fix inspector-searchinput-clear display behavior;

https://reviewboard.mozilla.org/r/72194/#review70196
Attachment #8781860 - Flags: review?(gl) → review+
Ouch I forgot this issue. Now rebased, issue addressed, and add push a new try to make sure everything still works fine before landing
Keywords: checkin-needed
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/b42815cdefee
Fix inspector-searchinput-clear display behavior; r=gl
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b42815cdefee
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Iteration: --- → 51.2 - Aug 29
Priority: P3 → P1
Reproduced on 51.0a1 2016-08-29.

Confirmed as fixed with 51.0a1 Nightly from 2016-08-30 under Win 10 64-bit, Ubuntu 16.04 64-bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qe-dthtml]
status-firefox51: fixed → verified
Flags: qe-verify+
QA Contact: cristian.comorasu → petruta.rasa
Thanks all.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: