Closed Bug 1295161 Opened 3 years ago Closed 3 years ago

[RTL][networkmonitor] Collapse/Expand pane button is not properly displayed

Categories

(DevTools :: General, defect, P2)

47 Branch
defect

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: itiel_yn8, Assigned: gasolin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Following bug 1285528, its patch apparently fixes only the Inspector tab, while other tabs such as Debugger and Network Monitor still have the incorrectly inverted Collapse/Expand pane button.

I guess the same patch should be applied to other tabs having this button in RTL.
Since new debugger frontend `devtools.debugger.new-debugger-frontend` does not contain toggle, I'd convert Network Monitor's toggle only.
Assignee: nobody → gasolin
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Summary: [RTL] Collapse/Expand pane button is not properly displayed → [RTL][networkmonitor] Collapse/Expand pane button is not properly displayed
Network monitor seems not work well with side mode at all, so I didn't add related toggle style like I did in bug 1285528
Comment on attachment 8783864 [details]
Bug 1295161 - [RTL] Network Monitor's Collapse/Expand pane button is not properly displayed;

https://reviewboard.mozilla.org/r/73530/#review71362

r=me with the rules combined.

::: devtools/client/themes/netmonitor.css:507
(Diff revision 1)
> -#details-pane-toggle {
> +#details-pane-toggle:-moz-locale-dir(ltr) {
>    list-style-image: var(--theme-pane-collapse-image);
>  }
>  
> -#details-pane-toggle.pane-collapsed {
> +#details-pane-toggle:-moz-locale-dir(rtl) {
>    list-style-image: var(--theme-pane-expand-image);
>  }
>  
> +#details-pane-toggle.pane-collapsed:-moz-locale-dir(ltr) {
> +  list-style-image: var(--theme-pane-expand-image);
> +}
> +
> +#details-pane-toggle.pane-collapsed:-moz-locale-dir(rtl) {
> +  list-style-image: var(--theme-pane-collapse-image);
> +}
> +

Can you combine those 4 rules into 2 rules using lists of selectors ?

::: devtools/client/themes/netmonitor.css:507
(Diff revision 1)
> -#details-pane-toggle {
> +#details-pane-toggle:-moz-locale-dir(ltr) {
>    list-style-image: var(--theme-pane-collapse-image);
>  }
>  
> -#details-pane-toggle.pane-collapsed {
> +#details-pane-toggle:-moz-locale-dir(rtl) {
>    list-style-image: var(--theme-pane-expand-image);
>  }
>  
> +#details-pane-toggle.pane-collapsed:-moz-locale-dir(ltr) {
> +  list-style-image: var(--theme-pane-expand-image);
> +}
> +
> +#details-pane-toggle.pane-collapsed:-moz-locale-dir(rtl) {
> +  list-style-image: var(--theme-pane-collapse-image);
> +}
> +

Can you combine those 4 rules into 2 rules using lists of selectors ?
Attachment #8783864 - Flags: review?(ntim.bugs) → review+
issue addressed, thanks!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/94cdf3006804
[RTL] Network Monitor's Collapse/Expand pane button is not properly displayed; r=ntim
Keywords: checkin-needed
Thank you guys!
Will the patch be available on tomorrow's Firefox Developer Edition?
Can't try to see if it works on Nightly as its only language is English, and using ForceRTL isn't always suitable for confirming that such issues are fixed.
https://hg.mozilla.org/mozilla-central/rev/94cdf3006804
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.