1295244 - Stylo Assertion failure: mURIResolved && aOther.mURIResolved in layout/style/nsCSSValue.cpp

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Chris Peterson [:cpeterson]]

I hit the following CSS assertion failure when trying to open about:home with a Stylo debug build:

Assertion failure: mURIResolved && aOther.mURIResolved (How do you know the URIs aren't null?), at /Users/chris/Code/mozilla/stylo-gecko/layout/style/nsCSSValue.cpp:2644
#01: nsChangeHint nsStyleContext::CalcStyleDifferenceInternal<FakeStyleContext>(FakeStyleContext*, nsChangeHint, unsigned int*, unsigned int*)[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x32abec0]
#02: nsStyleContext::CalcStyleDifference(ServoComputedValues*, nsChangeHint, unsigned int*, unsigned int*)[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3282555]
#03: Gecko_CalcStyleDifference[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x31824a2]
#04: _$LT$wrapper..GeckoRestyleDamage$u20$as$u20$style..dom..TRestyleDamage$GT$::compute::_$u7b$$u7b$closure$u7d$$u7d$::h8dcffd9544a2206b[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50f09ca]
#05: _$LT$style..gecko_glue..ArcHelpers$LT$GeckoType$C$$u20$ServoType$GT$$GT$::borrow::h534a3923f0bd638e[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50f0980]
#06: _$LT$wrapper..GeckoRestyleDamage$u20$as$u20$style..dom..TRestyleDamage$GT$::compute::hd2d9ea5010877a8c[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50d5721]
#07: style::matching::MatchMethods::compute_restyle_damage::h443aa71c1c9d3b8b[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50de17d]
#08: style::matching::MatchMethods::compute_damage_and_cascade_pseudos::h83a9e92c9b017dc4[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50e5ee2]
#09: style::matching::MatchMethods::cascade_node::hf1ec882ec52fe5e6[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50ddf27]
#10: style::traversal::recalc_style_at::h33ee7468db1be352[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50cf62c]
#11: _$LT$traversal..RecalcStyleOnly$LT$$u27$lc$GT$$u20$as$u20$style..traversal..DomTraversalContext$LT$wrapper..GeckoNode$LT$$u27$ln$GT$$GT$$GT$::process_preorder::he3ec031148eea97c[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x509b0f4]
#12: style::parallel::top_down_dom::ha36324ecce2ee277[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50b1744]
#13: _$LT$style..workqueue..WorkerThread$LT$QueueData$C$$u20$WorkData$GT$$GT$::start::h8b036150417ec0cc[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5087e89]
#14: _$LT$style..workqueue..WorkQueue$LT$QueueData$C$$u20$WorkData$GT$$GT$::new::_$u7b$$u7b$closure$u7d$$u7d$::h27ee7893cf23f4d3[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50871e9]
#15: std::thread::Builder::spawn::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::hd6e3f93ca9572e8d[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5086b9c]
#16: std::sys_common::unwind::try::try_fn::h9bb5b79e98276a02[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5086b03]
#17: __rust_try[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5b19fdc]
#18: std::sys_common::unwind::inner_try::h9eebd8dc83f388a6[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5b19f64]
#19: std::sys_common::unwind::try::h6b033917e5a286ec[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5086a4a]
#20: std::thread::Builder::spawn::_$u7b$$u7b$closure$u7d$$u7d$::he0b8f51af74c1b17[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x508686e]
#21: _$LT$F$u20$as$u20$std..boxed..FnBox$LT$A$GT$$GT$::call_box::hcd129e412a2327d7[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50874c5]
#22: std::sys::thread::Thread::new::thread_start::h471ad90789353b5b[/Users/chris/Code/mozilla/stylo-gecko/objdir-osx/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5b27b69]
#23: _pthread_body[/usr/lib/system/libsystem_pthread.dylib +0x399d]
#24: _pthread_body[/usr/lib/system/libsystem_pthread.dylib +0x391a]

Comment 1

[Bobby Holley (:bholley)]

I think emilio has a patch for this somewhere?

Comment 2

[Cameron McCormack (:heycam)]

This should be handled by the last patch in bug 1292930.

Comment 3

[Cameron McCormack (:heycam)]

If bug 1292930 didn't handle it then the re-worked URLValue comparisons from bug 1297963 should have.  Chris, please re-open if you're still seeing URLValue comparison related assertions.