Update copy for "Custom Tabs" in Settings

RESOLVED FIXED in Firefox 52

Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: antlam, Assigned: sebastian)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [MobileAS])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
Our copy for the Custom Tabs setting is not consistent with the rest of our language. Let's fix this.

Michelle, do you have any thoughts on this?

Custom Tabs [1] seems to be the right label, but I'm not sure about the description. 

Current:

Custom Tabs
Allow third party apps to open URLs with a customized look and feel

Proposed:
Custom Tabs

[1] https://developer.chrome.com/multidevice/android/customtabs
(Reporter)

Comment 1

a year ago
Ni-ing Michelle
Flags: needinfo?(mheubusch)
Note that this is a Nightly only setting and is unlikely to ship. (Right now the feature is too broken to be enabled by default, that's why we are showing a setting for devs/testers in Nightly).

Comment 3

a year ago
Custom Tabs
Allow apps to open websites using a customized version of Firefox
(Reporter)

Comment 4

a year ago
Thanks Michelle!
Flags: needinfo?(s.kaspari)
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Flags: needinfo?(s.kaspari)
Comment hidden (mozreview-request)

Updated

a year ago
Flags: needinfo?(mheubusch) → needinfo?

Comment 6

a year ago
mozreview-review
Comment on attachment 8798501 [details]
Bug 1295340 - Custom tabs string: Use &brandShortName; instead of 'Firefox'.

https://reviewboard.mozilla.org/r/83972/#review82624
Attachment #8798501 - Flags: review?(gkruglov) → review+

Comment 7

a year ago
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ff08c7cfb55d
Update copy for "Custom Tabs" in Settings. r=Grisha

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ff08c7cfb55d
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Are you use you want Firefox instead of &brandShortName;?
Flags: needinfo?
(In reply to Francesco Lodolo [:flod] from comment #9)
> Are you use you want Firefox instead of &brandShortName;?

Oh, damn. This should be &brandShortName; of course. Should I update the key again when changing that (pref_custom_tabs_summary2 -> pref_custom_tabs_summary3)?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Sebastian Kaspari (:sebastian) from comment #10)
> Oh, damn. This should be &brandShortName; of course. Should I update the key
> again when changing that (pref_custom_tabs_summary2 ->
> pref_custom_tabs_summary3)?

At this point yes, you need an updated string ID.
Comment hidden (mozreview-request)

Comment 13

a year ago
mozreview-review
Comment on attachment 8798501 [details]
Bug 1295340 - Custom tabs string: Use &brandShortName; instead of 'Firefox'.

https://reviewboard.mozilla.org/r/83972/#review83716
Attachment #8798501 - Flags: review?(francesco.lodolo) → review+

Comment 14

a year ago
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/70249b325a4e
Custom tabs string: Use &brandShortName; instead of 'Firefox'. r=flod,Grisha
Priority: -- → P1
Whiteboard: [MobileAS]

Comment 15

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/70249b325a4e
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED
Iteration: --- → 1.6
You need to log in before you can comment on or make changes to this bug.