Update the background color of the one-off search buttons

VERIFIED FIXED in Firefox 55

Status

()

defect
P1
normal
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: adw, Assigned: adw)

Tracking

Trunk
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 affected, firefox55 verified)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Assignee

Comment 2

3 years ago
Working on this as part of bug 1295458.
Assignee: nobody → adw
Status: NEW → ASSIGNED
Depends on: 1295458
Blocks: 1337003
Assignee

Comment 3

2 years ago
I'm narrowing this bug's focus specifically to the one-off buttons' new gray background color, since bug 1295458 takes care of the hover and selection colors.  That's the only thing left to do regarding the one-offs in Stephen's mockup in comment 0.  The color should match the gray color of the one-offs header.
Summary: Tweak visual styling for one-off search buttons → Update the background color of the one-off search buttons
Comment hidden (mozreview-request)
Stephen, what's the goal of this change? My impression is that it makes the one-off buttons less noticeable/discoverable, and the icons harder to 'read', due to a lower contrast between them and their background.
Flags: needinfo?(shorlander)
The goal is to visually separate the primary actions (top: results) from the secondary actions (bottom: non-default search engines). It also visually groups these two sections.

I am not sure it really affect emphasis. It's unlikely to affect discoverablily one way or the other.
Flags: needinfo?(shorlander)
After trying the patch, I think it looks OK on the awesomebar panel, but I dislike its appearance on the searchbar panel http://i.imgur.com/jRdD8Rt.png And it's even worse when the searchbar is empty and the user just clicks the glass icon: all of the panel's background is gray in this case http://i.imgur.com/pRUyL7z.png .

If we do go ahead with this change, I think we'll need to also apply it to open search items as the lighter item looks like a bug here: http://i.imgur.com/AVYhS9c.png.

Stephen, are these screenshots what you expect?
Flags: needinfo?(shorlander)
Comment hidden (mozreview-request)
Assignee

Comment 9

2 years ago
Fixes add-engine and the non-compact settings buttons.
I am fine with the appearance. I do agree that the add search item row should match.
Flags: needinfo?(shorlander)
Assignee

Comment 11

2 years ago
Stephen commented in comment 10, wanted to make sure you saw it.
Flags: needinfo?(florian)

Comment 12

2 years ago
mozreview-review
Comment on attachment 8854363 [details]
Bug 1295460 - Update the background color of the one-off search buttons.

https://reviewboard.mozilla.org/r/126298/#review133818
Attachment #8854363 - Flags: review?(florian) → review+
Flags: needinfo?(florian)

Comment 13

2 years ago
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71005756f3fb
Update the background color of the one-off search buttons. r=florian

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/71005756f3fb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Verified as fixed using the latest Nightly 55.0a1 (Build ID: 20170419030223) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12 - the background color of the one-off search buttons is updated as in the mock-up from the Description.

During verification, I observed some painting issue in the search bar on Ubuntu, logged Bug 1357800 to cover this.
Assignee

Updated

2 years ago
Depends on: 1357800
No longer depends on: 1357800
Based on Comment 15, marking this as Verified Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.