Closed Bug 1295488 Opened 7 years ago Closed 7 years ago

Mozscreenshots ControlCenter localFile configuration is constantly triggering differences

Categories

(Testing :: mozscreenshots, defect, P2)

Product:
Testing
Component:
mozscreenshots
Type:
defect

Tracking

(firefox51 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: johannh, Assigned: johannh)

Details

(Keywords: regression, Whiteboard: [fxprivacy] )

Attachments

(1 file)

Bug 1295488 - Don't use a directory for mozscreenshots localFile tests.
58 bytes, text/x-review-board-request
MattN
: review+
Details 
Through showing changing dates in the file list of file:///. We should point to a local file instead.
Probably simplest to resolve mozscreenshots.html to a file URI. IIRC there is an API to resolve a chrome URI (chrome://mozscreenshots/content/lib/mozscreenshots.html) to a file URI .
Keywords: regression
Priority: -- → P2
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Comment on attachment 8781867 [details]
Bug 1295488 - Don't use a directory for mozscreenshots localFile tests.

https://reviewboard.mozilla.org/r/72210/#review69772

Please review the localFile screenshots and the URLs in the address bar to make sure the URL doesn't change based upon the machine or other variables. If not, then r+.

Linux opt looks fine: https://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/40a7e521e296ed7ed62bc9ee1f7f5e3735f89453866f9fd39493bb9671e27a2eeac70827af114d93d8aff3ce18755b79fe04148e4139112cab002b7564f9f78f
Attachment #8781867 - Flags: review?(MattN+bmo) → review+
Yup, timing out on Windows again, I'll boot up my VM :(
Comment on attachment 8781867 [details]
Bug 1295488 - Don't use a directory for mozscreenshots localFile tests.

https://reviewboard.mozilla.org/r/72210/#review69968
https://hg.mozilla.org/integration/fx-team/rev/a6f67ab4a4ec4dd66f53c4b4423e5b8b63023388
Bug 1295488 - Don't use a directory for mozscreenshots localFile tests. r=MattN
https://hg.mozilla.org/mozilla-central/rev/a6f67ab4a4ec
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Component: General → mozscreenshots
Product: Firefox → Testing
Target Milestone: Firefox 51 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.