Closed Bug 1295491 Opened 5 years ago Closed 5 years ago

Remove Reference() component in grip-array.js

Categories

(DevTools :: Shared Components, defect)

Product:
DevTools
Component:
Shared Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: evanxd, Assigned: evanxd)

Details

Attachments

(1 file)

bug-1295491.patch
3.05 KB, patch
Honza
: review+
Details | Diff | Splinter Review 
Remove Reference() component in grip-array.js.
Hi Honza,

Could you help to review the patch?

Thanks.
Attachment #8781409 - Flags: review?(odvarko)
Comment on attachment 8781409 [details] [diff] [review]
bug-1295491.patch

Review of attachment 8781409 [details] [diff] [review]:
-----------------------------------------------------------------

R+ assuming try is green.

Thanks
Honza
Attachment #8781409 - Flags: review?(odvarko) → review+
Thanks for the review, Honza.

Sorry, forgot the try push. Added it here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=09531791ec14
The try is good. Do checkin-needed.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/457c3fe90f5f
Remove Reference component in grip-array.js. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/457c3fe90f5f
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.