All users were logged out of Bugzilla on October 13th, 2018

Remove Reference() component in grip-array.js

RESOLVED FIXED in Firefox 51

Status

RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: evanxd, Assigned: evanxd)

Tracking

unspecified
Firefox 51

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Remove Reference() component in grip-array.js.
(Assignee)

Comment 1

2 years ago
Created attachment 8781409 [details] [diff] [review]
bug-1295491.patch

Hi Honza,

Could you help to review the patch?

Thanks.
Attachment #8781409 - Flags: review?(odvarko)
Comment on attachment 8781409 [details] [diff] [review]
bug-1295491.patch

Review of attachment 8781409 [details] [diff] [review]:
-----------------------------------------------------------------

R+ assuming try is green.

Thanks
Honza
Attachment #8781409 - Flags: review?(odvarko) → review+
(Assignee)

Comment 3

2 years ago
Thanks for the review, Honza.

Sorry, forgot the try push. Added it here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=09531791ec14
(Assignee)

Comment 4

2 years ago
The try is good. Do checkin-needed.
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/457c3fe90f5f
Remove Reference component in grip-array.js. r=Honza
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/457c3fe90f5f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.