1295523 - No picture preview in file picker when picture width or height is larger than 4096px

Status: RESOLVED WONTFIX

(Core :: Widget: Gtk, defect)

Description

[denis]

Attachment: no picture preview can be seen

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160729072959

Steps to reproduce:

1. Go to a website where you can upload a picture, eg. http://tineye.com/ ;
2. Hit the upload button, this will open the Firefox's file explorer ;
3. Find a picture with lower case .jpg extension and enjoy the preview ;
4. Now, check with a picture with an upper case .JPG extension.

NB : This was tested on FF 48, under GNU/Linux, Fedora 24 kernel 4.6.5-300.fc24.x86_64.
Please note that this seems on happen only on some JPG files. However those exact same files have picture preview under latest Vivaldi and Chrome on the same platform.


Actual results:

The picture preview can't be seen.


Expected results:

There should be a picture preview.

Comment 1

[Tooru Fujisawa [:arai]]

Can you check the following?
  * copy the upper case .JPG file (say IMG_1230.JPG) to IMG_1230_lower.jpg (lower case), and see if the preview is shown or not
  * copy some lower case .jpg file (that preview is shown) to some.JPG (upper case), and see if the preview is shown or not

it will tell us whether the issue comes from the extension's case or the file itself.

Comment 2

[Justin [:JW_SoftvisionQA]]

I can not reproduce this issue on my machine Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0

Comment 3

[denis]

(In reply to Tooru Fujisawa [:arai] from comment #1)
> Can you check the following?
>   * copy the upper case .JPG file (say IMG_1230.JPG) to IMG_1230_lower.jpg
> (lower case), and see if the preview is shown or not
>   * copy some lower case .jpg file (that preview is shown) to some.JPG
> (upper case), and see if the preview is shown or not
> 
> it will tell us whether the issue comes from the extension's case or the
> file itself.

Hi;

I am pretty sure I already replied to this, but can't find it anywhere.

As I was saying, following the tests you suggested, it doesn't seem to be a case issue but more probably something directly linked to the picture I shot with a Canon Powershot SX60HS.

I can provide one of those files in case it helps.

Comment 4

[Tooru Fujisawa [:arai]]

thanks.

yeah, the file will help investigating the issue.
can you upload one?

Comment 5

[denis]

Attachment: IMG_1260.JPG

Here comes the file.

Comment 6

[Tooru Fujisawa [:arai]]

Thanks again :)
I resized the image to several sizes, and the result is the following:

  size                   | preview
 ------------------------+-----------
  4608 x 3456 (original) | not shown
  4096 x 3456            | shown
  4097 x 3456            | not shown
  4097 x  100            | not shown
  4096 x 4096            | shown
  4096 x 4097            | not shown
   100 x 4097            | not shown

Apparently the preview is not shown if one of width or height is larger than 4096px.
This seems to be from the patch for bug 1184009.

https://dxr.mozilla.org/mozilla-central/rev/f97a056ae6235de7855fd8aaa04fb1c8d183bd06/widget/gtk/nsFilePicker.cpp#33
> #define MAX_PREVIEW_SOURCE_SIZE 4096


lsalzman, will this be WONTFIX, or can we increase MAX_PREVIEW_SOURCE_SIZE value ?

Comment 7

[Lee Salzman [:lsalzman]]

(In reply to Tooru Fujisawa [:arai] from comment #6)
> Thanks again :)
> I resized the image to several sizes, and the result is the following:
> 
>   size                   | preview
>  ------------------------+-----------
>   4608 x 3456 (original) | not shown
>   4096 x 3456            | shown
>   4097 x 3456            | not shown
>   4097 x  100            | not shown
>   4096 x 4096            | shown
>   4096 x 4097            | not shown
>    100 x 4097            | not shown
> 
> Apparently the preview is not shown if one of width or height is larger than
> 4096px.
> This seems to be from the patch for bug 1184009.
> 
> https://dxr.mozilla.org/mozilla-central/rev/
> f97a056ae6235de7855fd8aaa04fb1c8d183bd06/widget/gtk/nsFilePicker.cpp#33
> > #define MAX_PREVIEW_SOURCE_SIZE 4096
> 
> 
> lsalzman, will this be WONTFIX, or can we increase MAX_PREVIEW_SOURCE_SIZE
> value ?

We can't go larger without risking bug 1184009. So this will have to remain WONTFIX.

Comment 8

[Tooru Fujisawa [:arai]]

Thanks!

closing as WONTFIX per comment 7.

so, this is hard-coded limitation for the size of the preview-able image file,
and we can show preview when both width and height fits 4096px.