1295531 - Inconsistency at arrow icon size in awesome screen

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P2)

Description

[Sorina Florean [:sflorean]]

Attachment: Screenshot_2016-08-16-10-48-10.jpg

Environment: 
Device: Asus ZenPad 8 (Android 5.0.2);
Build: Nightly 51.0a1 (2016-08-15);

Steps to reproduce:
1. Launch Firefox.
2. Go to Bookmarks Panel;
3. Tap on Desktop Bookmarks and observe the "back" arrow;
4. Go to History Panel;
5. Tap on Synced devices and observe the "back" arrow.

Expected result:
Bookmark "back" arrow and history "back" arrow have the same size.

Actual result:
Bookmark folder "back" arrow is bigger than history folder "back" arrow.

Notes:
Please see the attached screenshot.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

antlam: Which one is correct? :)

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> antlam: Which one is correct? :)

Weird! 

The left one is the correct one!

Comment 3

[Arseny Malkov]

I want to take this bug as my first bug, how can I do it?

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Arseny Malkov from comment #3)
> I want to take this bug as my first bug, how can I do it?

Yeah, sure! After uploading a first patch we will assign the bug to you.

If you haven't already then start by setting up your build system (A front-end build will be sufficient):
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

For this bug you'll have to investigate what's causing the different sizes: Are those the same images? Did the scaling of the imageview change? ...?

Comment 5

[Arseny Malkov]

Attachment: Bug_1295531___Change_inset_of_bookmark_arrow_to_look_like_history_arrow_[1].patch

Images are the same. Bookmark arrow is a drawable inside textview while history arrow is the content of imageview.

Comment 6

[Arseny Malkov]

(In reply to Arseny Malkov from comment #5)
> Created attachment 8787731 [details] [diff] [review]
> Bug_1295531___Change_inset_of_bookmark_arrow_to_look_like_history_arrow_[1].
> patch
> 
> Images are the same. Bookmark arrow is a drawable inside textview while
> history arrow is the content of imageview.
Vice versa. History arrow is a drawable inside textview while bookmark arrow is the content of imageview.

Comment 7

[Arseny Malkov]

Attachment: Bug_1295531___Change_inset_of_bookmark_arrow_to_look_like_history_arrow_1[1].patch

Forgot to change inset Bottom.

Comment 8

[Sorina Florean [:sflorean]]

Hey - I am gonna take care of this from the QA side - assigning it to me ( sorry Arseny Malkov- i choose first the wrong field).

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8787849 [details] [diff] [review]
Bug_1295531___Change_inset_of_bookmark_arrow_to_look_like_history_arrow_1[1].patch

Review of attachment 8787849 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry that this took so long. The change looks good to me. I tried it on the Nexus 9 and the arrows now seem to have the same size. Thank you!

I'll take care of landing the patch - a try run won't be necessary for this XML layout change.

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1295531 - Change insets of bookmark arrow to look like history arrow.

Review commit: https://reviewboard.mozilla.org/r/77586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77586/

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8789311 [details]
Bug 1295531 - Change insets of bookmark arrow to look like history arrow.

https://reviewboard.mozilla.org/r/77586/#review75844

Comment 12

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62a0fb3534ce006b583d8907d9df94a24a5f8ab0
Bug 1295531 - Change insets of bookmark arrow to look like history arrow. r=sebastian

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62a0fb3534ce
Change insets of bookmark arrow to look like history arrow. r=sebastian

Comment 14

[Sebastian Kaspari (:sebastian; :pocmo)]

@Arseny: If you would like to work on another bug.. bug 1301448 is in the same area of the code. :)

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/62a0fb3534ce

Comment 16

[Arseny Malkov]

(In reply to Sebastian Kaspari (:sebastian) from comment #14)
> @Arseny: If you would like to work on another bug.. bug 1301448 is in the
> same area of the code. :)
Thanks, I will take it :)

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Is it something that we would like to uplift to 50?

Comment 18

[Sorina Florean [:sflorean]]

Verified as fixed in build 51.0a1 (2016-09-15);
Device: Asus ZenPad 8 (Android 5.0.2).