Closed Bug 1295531 Opened 3 years ago Closed 3 years ago

Inconsistency at arrow icon size in awesome screen

Categories

(Firefox for Android :: Awesomescreen, defect, P2)

ARM
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox49 --- wontfix
firefox50 --- affected
firefox51 --- verified

People

(Reporter: sflorean, Assigned: arsenymalkov, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=java][good first bug][TPE-1])

Attachments

(2 files, 2 obsolete files)

Environment: 
Device: Asus ZenPad 8 (Android 5.0.2);
Build: Nightly 51.0a1 (2016-08-15);

Steps to reproduce:
1. Launch Firefox.
2. Go to Bookmarks Panel;
3. Tap on Desktop Bookmarks and observe the "back" arrow;
4. Go to History Panel;
5. Tap on Synced devices and observe the "back" arrow.

Expected result:
Bookmark "back" arrow and history "back" arrow have the same size.

Actual result:
Bookmark folder "back" arrow is bigger than history folder "back" arrow.

Notes:
Please see the attached screenshot.
antlam: Which one is correct? :)
Flags: needinfo?(alam)
Priority: -- → P2
(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> antlam: Which one is correct? :)

Weird! 

The left one is the correct one!
Flags: needinfo?(alam) → needinfo?(s.kaspari)
Mentor: s.kaspari, ahunt
Flags: needinfo?(s.kaspari)
Whiteboard: [lang=java][good first bug][TPE-1]
I want to take this bug as my first bug, how can I do it?
(In reply to Arseny Malkov from comment #3)
> I want to take this bug as my first bug, how can I do it?

Yeah, sure! After uploading a first patch we will assign the bug to you.

If you haven't already then start by setting up your build system (A front-end build will be sufficient):
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

For this bug you'll have to investigate what's causing the different sizes: Are those the same images? Did the scaling of the imageview change? ...?
Images are the same. Bookmark arrow is a drawable inside textview while history arrow is the content of imageview.
(In reply to Arseny Malkov from comment #5)
> Created attachment 8787731 [details] [diff] [review]
> Bug_1295531___Change_inset_of_bookmark_arrow_to_look_like_history_arrow_[1].
> patch
> 
> Images are the same. Bookmark arrow is a drawable inside textview while
> history arrow is the content of imageview.
Vice versa. History arrow is a drawable inside textview while bookmark arrow is the content of imageview.
Forgot to change inset Bottom.
Attachment #8787731 - Attachment is obsolete: true
Flags: needinfo?(s.kaspari)
Assignee: nobody → arsenymalkov
Status: NEW → ASSIGNED
Flags: needinfo?(s.kaspari)
Attachment #8787849 - Flags: review?(s.kaspari)
Assignee: arsenymalkov → sorina.florean
Assignee: sorina.florean → arsenymalkov
Hey - I am gonna take care of this from the QA side - assigning it to me ( sorry Arseny Malkov- i choose first the wrong field).
QA Contact: sorina.florean
Comment on attachment 8787849 [details] [diff] [review]
Bug_1295531___Change_inset_of_bookmark_arrow_to_look_like_history_arrow_1[1].patch

Review of attachment 8787849 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry that this took so long. The change looks good to me. I tried it on the Nexus 9 and the arrows now seem to have the same size. Thank you!

I'll take care of landing the patch - a try run won't be necessary for this XML layout change.
Attachment #8787849 - Flags: review?(s.kaspari) → review+
Comment on attachment 8789311 [details]
Bug 1295531 - Change insets of bookmark arrow to look like history arrow.

https://reviewboard.mozilla.org/r/77586/#review75844
Attachment #8789311 - Flags: review?(s.kaspari) → review+
Attachment #8789311 - Attachment is obsolete: true
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62a0fb3534ce
Change insets of bookmark arrow to look like history arrow. r=sebastian
@Arseny: If you would like to work on another bug.. bug 1301448 is in the same area of the code. :)
https://hg.mozilla.org/mozilla-central/rev/62a0fb3534ce
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
(In reply to Sebastian Kaspari (:sebastian) from comment #14)
> @Arseny: If you would like to work on another bug.. bug 1301448 is in the
> same area of the code. :)
Thanks, I will take it :)
Is it something that we would like to uplift to 50?
Verified as fixed in build 51.0a1 (2016-09-15);
Device: Asus ZenPad 8 (Android 5.0.2).
You need to log in before you can comment on or make changes to this bug.