1295570 - Rename DOMFileSystem to FileSystem

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: part 1 - DOMFileSystem

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8781554 [details] [diff] [review]
part 1 - DOMFileSystem

I assume you do first renaming and then in a separate bug remove NoInterfaceObject from all the relevant interfaces, right?
(Removing NoInterfaceObject will need also some test changes)

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 2 - Entry

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 3 - FileEntry

Comment 4

[Andrea Marchesini [:baku]]

Attachment: part 4 - DirectoryEntry

Comment 5

[Andrea Marchesini [:baku]]

Attachment: part 5 - DirectoryReader

Comment 6

[Andrea Marchesini [:baku]]

Attachment: part 6 - callbacks

Comment 7

[Andrea Marchesini [:baku]]

Attachment: part 7 - splitting webidl

Comment 8

[Andrea Marchesini [:baku]]

Attachment: part 8 - no interfacace object

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8781599 [details] [diff] [review]
part 4 - DirectoryEntry

I think RootFileSystemDirectoryEntry should be FileSystemRootDirectoryEntry
and change that also in the file name.

With that, r+

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8781606 [details] [diff] [review]
part 5 - DirectoryReader

Please wait for some feedback in the spec bug about this renaming before landing the patch.

RootFileSystemDirectoryReader should be FileSystemRootDirectoryReader

With those, r+

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8781611 [details] [diff] [review]
part 6 - callbacks

I wouldn't mind if you proposed the .webidl changes to the spec too, even though they aren't web visible changes.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a2fb47745f5
Entries API - part 1 - Rename DOMFileSystem to FileSystem, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad743a3522d4
Entries API - part 2 - Rename Entry to FileSystemEntry, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5f5a110ff9e
Entries API - part 3 - Rename FileEntry to FileSystemFileEntry, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3deb006faab
Entries API - part 4 - Rename DirectoryEntry to FileSystemDirectoryEntry, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a589e795dcf
Entries API - part 5 - Rename DirectoryReader to FileSystemDirectoryReader, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0e250259a5a
Entries API - part 6 - Rename Entries Callbacks, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/af544cf7fa1c
Entries API - part 7 - Split WebIDL files, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae927fbd31e2
Entries API - part 8 - Remove [NoInterfaceObject], r=smaug

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3a2fb47745f5
https://hg.mozilla.org/mozilla-central/rev/ad743a3522d4
https://hg.mozilla.org/mozilla-central/rev/a5f5a110ff9e
https://hg.mozilla.org/mozilla-central/rev/e3deb006faab
https://hg.mozilla.org/mozilla-central/rev/4a589e795dcf
https://hg.mozilla.org/mozilla-central/rev/b0e250259a5a
https://hg.mozilla.org/mozilla-central/rev/af544cf7fa1c
https://hg.mozilla.org/mozilla-central/rev/ae927fbd31e2