Closed Bug 1295570 Opened 3 years ago Closed 3 years ago

Rename DOMFileSystem to FileSystem

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(8 files)

No description provided.
Attachment #8781554 - Flags: review?(bugs)
Comment on attachment 8781554 [details] [diff] [review]
part 1 - DOMFileSystem

I assume you do first renaming and then in a separate bug remove NoInterfaceObject from all the relevant interfaces, right?
(Removing NoInterfaceObject will need also some test changes)
Attachment #8781554 - Flags: review?(bugs) → review+
Attached patch part 2 - EntrySplinter Review
Attachment #8781589 - Flags: review?(bugs)
Attachment #8781598 - Flags: review?(bugs)
Attachment #8781599 - Flags: review?(bugs)
Attachment #8781606 - Flags: review?(bugs)
Attachment #8781611 - Flags: review?(bugs)
Attachment #8781617 - Flags: review?(bugs)
Attachment #8781618 - Flags: review?(bugs)
Attachment #8781589 - Flags: review?(bugs) → review+
Attachment #8781598 - Flags: review?(bugs) → review+
Comment on attachment 8781599 [details] [diff] [review]
part 4 - DirectoryEntry

I think RootFileSystemDirectoryEntry should be FileSystemRootDirectoryEntry
and change that also in the file name.

With that, r+
Attachment #8781599 - Flags: review?(bugs) → review+
Comment on attachment 8781606 [details] [diff] [review]
part 5 - DirectoryReader

Please wait for some feedback in the spec bug about this renaming before landing the patch.

RootFileSystemDirectoryReader should be FileSystemRootDirectoryReader

With those, r+
Attachment #8781606 - Flags: review?(bugs) → review+
Comment on attachment 8781611 [details] [diff] [review]
part 6 - callbacks

I wouldn't mind if you proposed the .webidl changes to the spec too, even though they aren't web visible changes.
Attachment #8781611 - Flags: review?(bugs) → review+
Attachment #8781617 - Flags: review?(bugs) → review+
Attachment #8781618 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a2fb47745f5
Entries API - part 1 - Rename DOMFileSystem to FileSystem, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad743a3522d4
Entries API - part 2 - Rename Entry to FileSystemEntry, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5f5a110ff9e
Entries API - part 3 - Rename FileEntry to FileSystemFileEntry, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3deb006faab
Entries API - part 4 - Rename DirectoryEntry to FileSystemDirectoryEntry, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a589e795dcf
Entries API - part 5 - Rename DirectoryReader to FileSystemDirectoryReader, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0e250259a5a
Entries API - part 6 - Rename Entries Callbacks, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/af544cf7fa1c
Entries API - part 7 - Split WebIDL files, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae927fbd31e2
Entries API - part 8 - Remove [NoInterfaceObject], r=smaug
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.