1295610 - localization: migrate toolbox to use l10n.js instead of Services.string

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[Julian Descottes [:jdescottes]]

In the scope of devtools html, the LocalizationHelper in l10n.js will be migrated to no longer depend on Services.string. 

Migrate all existing toolbox classes to use this helper instead of directly relying on Services.string.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1295610 - Fixup for devtools/client/framework l10n.js migration;

Review commit: https://reviewboard.mozilla.org/r/72996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72996/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8783000 [details]
Bug 1295610 - Fixup for devtools/client/framework l10n.js migration;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72996/diff/1-2/

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8783000 [details]
Bug 1295610 - Fixup for devtools/client/framework l10n.js migration;

https://reviewboard.mozilla.org/r/72996/#review71686

Thank you.  This is great to see.

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8783000 [details]
Bug 1295610 - Fixup for devtools/client/framework l10n.js migration;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72996/diff/2-3/

Comment 5

[Julian Descottes [:jdescottes]]

Last try push had (probably unrelated) failures in an aboutdebugging test. Rebased & resubmitted here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8582c0e8d6b0

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8783000 [details]
Bug 1295610 - Fixup for devtools/client/framework l10n.js migration;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72996/diff/3-4/

Comment 7

[Julian Descottes [:jdescottes]]

Comment on attachment 8783000 [details]
Bug 1295610 - Fixup for devtools/client/framework l10n.js migration;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72996/diff/4-5/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/bbbaa584248f
Migrate devtools/client/framework to use l10n.js instead of Services.string;r=tromey

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 8783000 [details]
Bug 1295610 - Fixup for devtools/client/framework l10n.js migration;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72996/diff/5-6/

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bbbaa584248f

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/444b23193a56
Fixup for devtools/client/framework l10n.js migration;r=tromey

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/444b23193a56