Closed Bug 1295687 Opened 4 years ago Closed 4 years ago

media/webrtc/trunk/testing/gtest/src/gtest-internal-inl.h:213:8: warning: private field 'pretty_' is not used [-Wunused-private-field]

Categories

(Core :: WebRTC, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

We spam this warning while building gtest inside of WebRTC:
{
$SRC/media/webrtc/trunk/testing/gtest/src/gtest-internal-inl.h:213:8: warning: private field 'pretty_' is not used [-Wunused-private-field]
  bool pretty_;
       ^
1 warning generated.
}

This was fixed in upstream "googletest" in 2013, 3.5 years ago (i.e. the unused variable was removed), here:
https://github.com/google/googletest/commit/1b89db97058ced81a116d6a03714fec9bd8fc721#diff-96d59933091e9175cab1f2b7dabf20aeL218

Our copy of this file hasn't been touched since 2012, though, in bug 797671.  Hence, it's still got this unused variable.

Not sure if we have plans to update our copy of this library -- but in the meantime, perhaps we can cherrypick the upstream fix & remove the unused variable? We actually already did this for a separate copy of this same file in our tree, in bug 1018270.
Rank: 29
Priority: -- → P2
Comment on attachment 8781657 [details]
Bug 1295687: Cherrypick -Wunused-private-field warning fix from upstream gtest into our gtest clone for webrtc.

https://reviewboard.mozilla.org/r/72034/#review70248
Comment on attachment 8781657 [details]
Bug 1295687: Cherrypick -Wunused-private-field warning fix from upstream gtest into our gtest clone for webrtc.

https://reviewboard.mozilla.org/r/72034/#review70250
Attachment #8781657 - Flags: review?(rjesup) → review+
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a70c7469c50
Cherrypick -Wunused-private-field warning fix from upstream gtest into our gtest clone for webrtc. r=jesup
https://hg.mozilla.org/mozilla-central/rev/8a70c7469c50
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.