1295687 - media/webrtc/trunk/testing/gtest/src/gtest-internal-inl.h:213:8: warning: private field 'pretty_' is not used [-Wunused-private-field]

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Daniel Holbert [:dholbert]]

We spam this warning while building gtest inside of WebRTC:
{
$SRC/media/webrtc/trunk/testing/gtest/src/gtest-internal-inl.h:213:8: warning: private field 'pretty_' is not used [-Wunused-private-field]
  bool pretty_;
       ^
1 warning generated.
}

This was fixed in upstream "googletest" in 2013, 3.5 years ago (i.e. the unused variable was removed), here:
https://github.com/google/googletest/commit/1b89db97058ced81a116d6a03714fec9bd8fc721#diff-96d59933091e9175cab1f2b7dabf20aeL218

Our copy of this file hasn't been touched since 2012, though, in bug 797671.  Hence, it's still got this unused variable.

Not sure if we have plans to update our copy of this library -- but in the meantime, perhaps we can cherrypick the upstream fix & remove the unused variable? We actually already did this for a separate copy of this same file in our tree, in bug 1018270.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1295687: Cherrypick -Wunused-private-field warning fix from upstream gtest into our gtest clone for webrtc.

Review commit: https://reviewboard.mozilla.org/r/72034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72034/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8781657 [details]
Bug 1295687: Cherrypick -Wunused-private-field warning fix from upstream gtest into our gtest clone for webrtc.

https://reviewboard.mozilla.org/r/72034/#review70248

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8781657 [details]
Bug 1295687: Cherrypick -Wunused-private-field warning fix from upstream gtest into our gtest clone for webrtc.

https://reviewboard.mozilla.org/r/72034/#review70250

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a70c7469c50
Cherrypick -Wunused-private-field warning fix from upstream gtest into our gtest clone for webrtc. r=jesup

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a70c7469c50