1295769 - Zoom indicator zoom effect could be smoother

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Justin Dolske [:Dolske]]

Bug 565718 added a zoom indicator to the URL bar. The first time it's shown, the indicator has a little animation to draw attention to it:

  @keyframes urlbar-zoom-reset-pulse {
    0% {
      transform: scale(0);
    }
    100% {
      transform: scale(1.5);
    }
  }

This feels a bit jarring to me, because at the end of the animation it snaps back to 100% instantly. Seems like this would be a little bit smoother if it was more of a "bounce".

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Bug 1295769 - Zoom indicator zoom effect could be smoother.

Review commit: https://reviewboard.mozilla.org/r/72088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72088/

Comment 2

[Justin Dolske [:Dolske]]

. o O (how do I always manage to click "take" next to QA Contact instead of assignee?)

IIRC the fancy-pants way to do this is with "animation-timing-function: cubic-bezier(mumble)", but I'm not sure if that works with @keyframes and this is pretty dead-simple.

Comment 3

[Stephen Horlander [:shorlander]]

The mockup I did was more of a pulse than a grow: http://people.mozilla.org/~shorlander/mockups-interactive/firefox-ui/zoom-indicator-osx-yosemite.html

Also avoids scaling the text (which seems pretty jaggy)

Comment 4

[Katie Broida [:ktbee]]

Comment on attachment 8781738 [details]
Bug 1295769 - Zoom indicator zoom effect could be smoother.

https://reviewboard.mozilla.org/r/72088/#review69868

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0efbd7c33fe
Zoom indicator zoom effect could be smoother. r=ktbee

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d0efbd7c33fe

Comment 7

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 51 beta 1 under Win 10 64-bit and Mac OS X 10.12. The animation is slightly smoother.