Closed
Bug 1295866
Opened 8 years ago
Closed 8 years ago
Remove special handling for easing: "function (a){return a}"
Categories
(Core :: DOM: Animation, defect, P3)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: birtles, Assigned: skoji)
References
Details
Attachments
(1 file)
In bug 1247004 we introduced an exception to the parsing of easing parameters to *not* throw a TypeError when we receive "function (a){return a}".[1] This was due to a bug in the web-animations polyfill used on many sites. Chrome introduced the same workaround. They have been monitoring usage of this and have found it has dropped off enough for them to remove this exception.[2] We should do the same. [1] http://searchfox.org/mozilla-central/rev/03b3c20a6ec60435feb995a2a23c5926188c85a1/dom/animation/TimingParams.cpp#165 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=601672#c15
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → skoji
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8785528 [details] Bug 1295866 : remove special handling for easing "function (a){return a}" https://reviewboard.mozilla.org/r/74704/#review72556 Looks good. Thank you!
Attachment #8785528 -
Flags: review?(bbirtles) → review+
Pushed by bbirtles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/703f04496b4e remove special handling for easing "function (a){return a}" r=birtles
|
|
Reporter | |
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=692c4891096e
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/703f04496b4e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•