1295895 - Correctly capitalize StyleFillRule

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Manish Goregaokar [:manishearth]]

The variants are currently NonZero and EvenOdd. The keywords are nonzero/evenodd, not non-zero and even-odd. Thus, the names should be Nonzero and Evenodd.

(This breaks servo codegen, and I'd rather not hack it to support this one edge case)

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1295895 - Correctly capitalize StyleFillRule;

Review commit: https://reviewboard.mozilla.org/r/72206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72206/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8781864 [details]
Bug 1295895 - Correctly capitalize StyleFillRule;

https://reviewboard.mozilla.org/r/72206/#review69738

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8781864 [details]
Bug 1295895 - Correctly capitalize StyleFillRule;

https://reviewboard.mozilla.org/r/72206/#review69740

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8781864 [details]
Bug 1295895 - Correctly capitalize StyleFillRule;

https://reviewboard.mozilla.org/r/72206/#review69744

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/587a4c621b5f
Correctly capitalize StyleFillRule; r=heycam

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/587a4c621b5f