Closed Bug 1295895 Opened 8 years ago Closed 8 years ago

Correctly capitalize StyleFillRule

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: manishearth, Assigned: manishearth)

Details

Attachments

(1 file)

The variants are currently NonZero and EvenOdd. The keywords are nonzero/evenodd, not non-zero and even-odd. Thus, the names should be Nonzero and Evenodd.

(This breaks servo codegen, and I'd rather not hack it to support this one edge case)
Comment on attachment 8781864 [details]
Bug 1295895 - Correctly capitalize StyleFillRule;

https://reviewboard.mozilla.org/r/72206/#review69738
Comment on attachment 8781864 [details]
Bug 1295895 - Correctly capitalize StyleFillRule;

https://reviewboard.mozilla.org/r/72206/#review69740
Comment on attachment 8781864 [details]
Bug 1295895 - Correctly capitalize StyleFillRule;

https://reviewboard.mozilla.org/r/72206/#review69744
Attachment #8781864 - Flags: review?(cam) → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/587a4c621b5f
Correctly capitalize StyleFillRule; r=heycam
https://hg.mozilla.org/mozilla-central/rev/587a4c621b5f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: