1295987 - git mozreview push generates lowercase HTTP header names, which can confuse broken proxies

Status: RESOLVED INVALID

(MozReview Graveyard :: Integration: Git, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I ported my gecko-dev checkout to cinnabar and set up MozReview following the instructions.  Now "git mozreview push" returns some SSL warnings (about SNI not being available and cert verification being disabled, should not be relevant) followed by

  urllib2.HTTPError: HTTP Error 403: Forbidden
  abort: error performing cinnabar push; please report this bug

In my git config, mozreview.remote is set to hg::https://reviewboard-hg.mozilla.org/gecko, which is what "git mozreview configure" set it to.

This blocks my use of MozReview for the moment.

Comment 1

[Gregory Szorc [:gps]]

Please post the actual command output. Fragments don't give us enough context to work on.

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I think this is a problem on my end.  I'll reopen if that proves not to be the case.

Comment 3

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I tracked down the problem.  "git mozreview push" generates the following HTTP request:

  GET http://reviewboard-hg.mozilla.org/gecko?cmd=capabilities HTTP/1.1
  Accept-Encoding: identity
  host: reviewboard-hg.mozilla.org
  accept: application/mercurial-0.1
  [etc.]

This is perfectly correct per spec, because HTTP header names are case-insensitive.  However, I happen to be trying to do all this behind a broken proxy that I think expects the header names to be capitalized, as is customary (I suspect "Host" is the problem).  I tried poking at things to see if I could find how to fix it, but I failed.  This is likely a problem that will only ever affect me, but do you know how to fix it, or where I should look to fix it?

Comment 4

[Gregory Szorc [:gps]]

You've got to be kidding me.

This is likely a bug in git-cinnabar since git-cinnabar is the thing generating the HTTP requests.

Comment 5

[Gregory Szorc [:gps]]

To clarify, I'm astounded the lowercase header problem is still a problem in 2016. I haven't seen this type of failure in several years. It saddens me that we'll have to work around it.

Comment 6

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

There are always going to be people who use regex or string-matching for scraping things instead of standards-conformant parsers, and they're only going to test on browsers, so anything that doesn't behave like a browser might break.  That's going to be a fact forever.  Which is basically just Postel's law.

Comment 7

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Do you know where this code might live?

Comment 8

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #4)
> You've got to be kidding me.
> 
> This is likely a bug in git-cinnabar since git-cinnabar is the thing
> generating the HTTP requests.

Not in the default configuration. In the default configuration, mercurial is.

Comment 9

[Mike Hommey [:glandium]]

and mercurial uses python's httplib iirc.

Comment 10

[Gregory Szorc [:gps]]

Does vanilla Mercurial exhibit the behavior or your misbehaving HTTP proxy? If so, then this is an upstream bug. If not, then there's something in the interaction of cinnabar or mozreview triggering it.

Comment 11

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I've confirmed that the issue is in hg, so I'll take the issue elsewhere.  Thanks, and sorry for the bother.

But as a workaround -- Mike, you said "in the default configuration".  Is there a way to get it to not use Mercurial?

Comment 12

[Mike Hommey [:glandium]]

(In reply to :Aryeh Gregor (working until September 2) from comment #11)
> But as a workaround -- Mike, you said "in the default configuration".  Is
> there a way to get it to not use Mercurial?

An experimental way, yes, on 0.4.0 beta. Build the helper (make helper, or download it from the github release page), and `git config cinnabar.experiments true`.