Closed
Bug 1296040
Opened 8 years ago
Closed 8 years ago
telemetry.js doesn't define global Telemetry
Categories
(DevTools :: Framework, enhancement, P1)
DevTools
Framework
Tracking
(firefox51 fixed)
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
(Whiteboard: [reserve-html])
Attachments
(1 file)
Like bug 1294187, telemetry.js uses "this.Telemetry = ...", but then refers to "Telemetry". This causes an error when trying to load the generated webpack.
| Comment hidden (mozreview-request) |
|
||
Updated•8 years ago
|
Iteration: --- → 51.2 - Aug 29
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8782070 [details] Bug 1296040 - correctly define Telemetry at top level; https://reviewboard.mozilla.org/r/72334/#review69936
Attachment #8782070 -
Flags: review?(bgrinstead) → review+
|
Assignee | |
Comment 3•8 years ago
|
||
Oops, missed an eslint complaint.
| Comment hidden (mozreview-request) |
Pushed by ttromey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d09a610855c1 correctly define Telemetry at top level; r=bgrins
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d09a610855c1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•