Closed Bug 1296040 Opened 4 years ago Closed 4 years ago

telemetry.js doesn't define global Telemetry

Categories

(DevTools :: Framework, enhancement, P1)

enhancement

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Iteration:
51.2 - Aug 29
Tracking Status
firefox51 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [reserve-html])

Attachments

(1 file)

Like bug 1294187, telemetry.js uses "this.Telemetry = ...", but then refers
to "Telemetry".  This causes an error when trying to load the generated webpack.
Iteration: --- → 51.2 - Aug 29
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
Comment on attachment 8782070 [details]
Bug 1296040 - correctly define Telemetry at top level;

https://reviewboard.mozilla.org/r/72334/#review69936
Attachment #8782070 - Flags: review?(bgrinstead) → review+
Oops, missed an eslint complaint.
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d09a610855c1
correctly define Telemetry at top level; r=bgrins
https://hg.mozilla.org/mozilla-central/rev/d09a610855c1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.