telemetry.js doesn't define global Telemetry

RESOLVED FIXED in Firefox 51

Status

()

Firefox
Developer Tools: Framework
P1
enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
Firefox 51
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [reserve-html])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Like bug 1294187, telemetry.js uses "this.Telemetry = ...", but then refers
to "Telemetry".  This causes an error when trying to load the generated webpack.
Comment hidden (mozreview-request)

Updated

2 years ago
Iteration: --- → 51.2 - Aug 29
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]

Comment 2

2 years ago
mozreview-review
Comment on attachment 8782070 [details]
Bug 1296040 - correctly define Telemetry at top level;

https://reviewboard.mozilla.org/r/72334/#review69936
Attachment #8782070 - Flags: review?(bgrinstead) → review+
(Assignee)

Comment 3

2 years ago
Oops, missed an eslint complaint.
Comment hidden (mozreview-request)

Comment 5

2 years ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d09a610855c1
correctly define Telemetry at top level; r=bgrins

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d09a610855c1
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.