1296040 - telemetry.js doesn't define global Telemetry

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

Like bug 1294187, telemetry.js uses "this.Telemetry = ...", but then refers
to "Telemetry".  This causes an error when trying to load the generated webpack.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1296040 - correctly define Telemetry at top level;

Review commit: https://reviewboard.mozilla.org/r/72334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72334/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8782070 [details]
Bug 1296040 - correctly define Telemetry at top level;

https://reviewboard.mozilla.org/r/72334/#review69936

Comment 3

[Tom Tromey :tromey]

Oops, missed an eslint complaint.

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8782070 [details]
Bug 1296040 - correctly define Telemetry at top level;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72334/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d09a610855c1
correctly define Telemetry at top level; r=bgrins

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d09a610855c1