Closed
Bug 1296048
Opened 8 years ago
Closed 8 years ago
Scope mozilla-specific CodeMirror CSS
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox51 fixed)
RESOLVED
FIXED
Firefox 51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: jlong, Assigned: jlong)
References
Details
Attachments
(1 file, 3 obsolete files)
|
1.77 KB,
patch
|
jlong
:
review+
|
Details | Diff | Splinter Review |
We are pulling in CodeMirror directly in the new debugger so we need to make sure all the CSS is appropriately scoped. It's a small patch that I'll attach in a second.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8782085 -
Flags: review?(gl)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jlong
|
||
Updated•8 years ago
|
Attachment #8782085 -
Flags: review?(gl) → review+
|
|
Assignee | |
Comment 2•8 years ago
|
||
Sorry, need a re-review. There were still conflicting styles with the breakpoints. I moved the debugger-specific CSS to only the debugger, is that ok? Now we can load breakpoints the way we want (we have a better breakpoint implementation)
Attachment #8782085 -
Attachment is obsolete: true
Attachment #8782509 -
Flags: review?(gl)
|
|
Assignee | |
Comment 3•8 years ago
|
||
This patch doesn't move the debug-line CSS in case other tools depend on that.
Attachment #8782509 -
Attachment is obsolete: true
Attachment #8782509 -
Flags: review?(gl)
Attachment #8782512 -
Flags: review?(gl)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Oops, nevermind, I can't move it because in the old debugger CodeMirror is loaded in an iframe, so that styles have to come with it. Sigh. I guess we'll have just to use different classNames in the new debugger. This patch is the same as the old patch that got r+
Attachment #8782512 -
Attachment is obsolete: true
Attachment #8782512 -
Flags: review?(gl)
Attachment #8782517 -
Flags: review+
Pushed by jlong@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/dce857dd57e2 scope codemirror styles better in devtools r=gl
|
|
Assignee | |
Comment 6•8 years ago
|
||
Very small CSS change so went ahead and pushed it
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dce857dd57e2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•