Closed Bug 1296048 Opened 3 years ago Closed 3 years ago

Scope mozilla-specific CodeMirror CSS

Categories

(DevTools :: Debugger, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: jlong, Assigned: jlong)

References

Details

Attachments

(1 file, 3 obsolete files)

We are pulling in CodeMirror directly in the new debugger so we need to make sure all the CSS is appropriately scoped. It's a small patch that I'll attach in a second.
Blocks: 1294139
Attached patch 1296048.patch (obsolete) — Splinter Review
Attachment #8782085 - Flags: review?(gl)
Assignee: nobody → jlong
Attachment #8782085 - Flags: review?(gl) → review+
Attached patch 1296048.patch (obsolete) — Splinter Review
Sorry, need a re-review. There were still conflicting styles with the breakpoints. I moved the debugger-specific CSS to only the debugger, is that ok? Now we can load breakpoints the way we want (we have a better breakpoint implementation)
Attachment #8782085 - Attachment is obsolete: true
Attachment #8782509 - Flags: review?(gl)
Attached patch 1296048.patch (obsolete) — Splinter Review
This patch doesn't move the debug-line CSS in case other tools depend on that.
Attachment #8782509 - Attachment is obsolete: true
Attachment #8782509 - Flags: review?(gl)
Attachment #8782512 - Flags: review?(gl)
Attached patch 1296048.patchSplinter Review
Oops, nevermind, I can't move it because in the old debugger CodeMirror is loaded in an iframe, so that styles have to come with it. Sigh. I guess we'll have just to use different classNames in the new debugger.

This patch is the same as the old patch that got r+
Attachment #8782512 - Attachment is obsolete: true
Attachment #8782512 - Flags: review?(gl)
Attachment #8782517 - Flags: review+
Pushed by jlong@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/dce857dd57e2
scope codemirror styles better in devtools r=gl
Very small CSS change so went ahead and pushed it
https://hg.mozilla.org/mozilla-central/rev/dce857dd57e2
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.