1296105 - Firefox uses OSX CoreGraphics API, should use CoreText API

Status: RESOLVED DUPLICATE of bug 1279962

(Firefox :: Shell Integration, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

Issue reported by Apple.

Please communicate with Firefox developers about the following problem regarding UI font usage in their app (Firefox 47 as of now):

The code uses CoreGraphics API to retrieve a font references, but sometimes the system can return a font name that is only understood by CoreText level API:

https://github.com/mozilla/gecko-dev/blob/master/gfx/thebes/gfxMacPlatformFontList.mm#L297

It needs to switch to CoreText API to properly interpret it.

Comment 1

[Lawrence Mandel [:lmandel] (use needinfo)]

Markus, can you look at this issue reported by Apple?

Comment 2

[Markus Stange [:mstange]]

We mostly fixed this in bug 1279962.

The new code does:

> NSFont* font = [NSFont fontWithName:psname size:mSizeHint];
> if (font) {
>   mFontRef = CTFontCopyGraphicsFont((CTFontRef)font, nullptr);
> }

NSFont* is CTFontRef, which is CoreText, so I think this addresses Apple's suggestion.