1296125 - position.timestamp is microseconds in native location providers

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect, P3)

Description

[Dietrich Ayala (:dietrich)]

<script>
  navigator.geolocation.watchPosition(function(position) {
    document.body.innerHTML = 'timestamp: ' + position.timestamp
      + ', new Date(timestamp): ' + new Date(position.timestamp);
  });
</script>

MDN says should be milliseconds:

https://developer.mozilla.org/en-US/docs/Web/API/Position/timestamp

Spec says should be milliseconds:

https://www.w3.org/TR/geolocation-API/#position

Fennec implements as milliseconds.




(If it were up to me, it'd be implemented in millivanilliseconds.)

Comment 1

[Dietrich Ayala (:dietrich)]

Confirmed this is only on Mac. Linux and Windows are unaffected.

Comment 2

[Doug Turner (:dougt)]

Thanks Dietrich.

Basically Mac (nightly?) uses the native location provider.  Most platforms use the network based on (GLS/MLS).


The bug on the mac is here:

https://dxr.mozilla.org/mozilla-central/source/dom/system/mac/CoreLocationLocationProvider.mm?q=CoreLocationLocationProvider.mm&redirect_type=direct#103

PR_Now() is defined in microseconds:

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSPR/Reference/PR_Now


I think we should just replace this PR_Now() with PR_IntervalToMicroseconds(PR_IntervalNow())


We should audit the other places we use PR_Now(). For example, windows does:

https://dxr.mozilla.org/mozilla-central/source/dom/system/windows/WindowsLocationProvider.cpp#176

Comment 3

[Doug Turner (:dougt)]

Attachment: bug_1296125_use_milliseconds

Comment 4

[Doug Turner (:dougt)]

Attachment: bug_1296125_use_milliseconds

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8784115 [details] [diff] [review]
bug_1296125_use_milliseconds

Review of attachment 8784115 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a425b5c3ae
Geolocation timestamp sometimes uses microseconds instead of milliseconds. r=kchen

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b4a425b5c3ae