1296207 - Remove billboard capability

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

The billboard hasn't been used since around 3.6 and the new UI that is being designed doesn't have support for a billboard so let's remove it in preparation of the new UI.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch - browser rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch - app update client rev1

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch - app update tests rev1

Comment 4

[Robert Strong (they/them - no direct email)]

Try push
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b285ddc218e

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch - puppeteer

From looking at the puppeteer files it appears that the same files are used by different versions of Firefox vs. using the files in tree that correspond to a Firefox version. This patch is mainly to give the people that maintain puppeteer a heads up of what is changing and they can decide based on how they use these tests what if anything in the patch they want.

Comment 6

[Robert Strong (they/them - no direct email)]

AUS Notes: platformVersion and support for billboardURL should be removed for the version that this lands for.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch - app update client rev1

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch - app update tests rev1

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 8782721 [details] [diff] [review]
patch - puppeteer

Filed bug 1296677 to fix the Firefox UI tests that aren't part of the build tests

Comment 10

[Robert Strong (they/them - no direct email)]

Additional try push just in case
https://treeherder.mozilla.org/#/jobs?repo=try&revision=35d115e21d9e

Comment 11

[Robert Strong (they/them - no direct email)]

Ben, They shouldn't cause any problems if they are still there but platformVersion and billboardURL should be removed from AUS for the version that this lands for.

Comment 12

[[e-mail] (:bhearsum)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #11)
> Ben, They shouldn't cause any problems if they are still there but
> platformVersion and billboardURL should be removed from AUS for the version
> that this lands for.

Thanks for the heads up. I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1296685 for the Balrog portion.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8782716 [details] [diff] [review]
patch - browser rev1

Review of attachment 8782716 [details] [diff] [review]:
-----------------------------------------------------------------

Are you going to remove http://searchfox.org/mozilla-central/rev/f433f0dd7158d7bfc4c4607161fc6baa88b5a9f4/toolkit/mozapps/update/content/updates.xul#108 too?

Comment 14

[Robert Strong (they/them - no direct email)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #13)
> Comment on attachment 8782716 [details] [diff] [review]
> patch - browser rev1
> 
> Review of attachment 8782716 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Are you going to remove
> http://searchfox.org/mozilla-central/rev/
> f433f0dd7158d7bfc4c4607161fc6baa88b5a9f4/toolkit/mozapps/update/content/
> updates.xul#108 too?
Yes, the removal is in attachment #8782956 [details] [diff] [review]

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

Cool, sounds good.

Comment 16

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8782956 [details] [diff] [review]
patch - app update client rev1

Review of attachment 8782956 [details] [diff] [review]:
-----------------------------------------------------------------

Ah yes, I do love patches that just remove a bunch of code. Feels nice at the end of a week.

Comment 17

[Robert Strong (they/them - no direct email)]

I'm going to wait on a response to bug 1296677 before landing.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4dd3335be87
Firefox code - Remove unused app update billboard capability. r=jaws
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf6750f13711
app update client code - Remove unused app update billboard capability. r=mhowell
https://hg.mozilla.org/integration/mozilla-inbound/rev/1716710ff71c
tests - Remove unused app update billboard capability. r=mhowell

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f4dd3335be87
https://hg.mozilla.org/mozilla-central/rev/bf6750f13711
https://hg.mozilla.org/mozilla-central/rev/1716710ff71c