1296252 - Permission notifications with different anchors are stacked together on Elm

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Johann Hofmann [:johannh]]

Attachment: Screen Shot 2016-08-18 at 12.34.55.png

See screenshot. I found two ways to trigger this so far (on Elm only!):

- go to https://permission.site/
- click on "Notifications" and "Location" without using the doorhangers
- navigate to a new tab
- close the new tab
- observe

and

- go to https://permission.site/
- click on "Camera" and "Location" without using the doorhanger
- click on "Notifications" and cancel the doorhanger by clicking the [x]
- observe

These shouldn't be grouped together since they belong to different anchors. Also, the stacking looks broken, but that will probably be handled in different bugs.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

I think the stacking happens in nightly as well, only vertically and it looks nicer since different heights don't affect it. I can't remember how to reproduce it there, but the anchoring problem should be the same. My guess is that the horizontal stacking changed in bug 1267604 (but it may even be from bug 1004061).

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Only display permission prompts when they are anchored to the right icon (bug 1296252).

Review commit: https://reviewboard.mozilla.org/r/72588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72588/

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

This patch works, but needs a test.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

I would say that verification is not strictly necessary in this case, as this is something that will land on elm. The comprehensive QA effort after the merge to m-c will cover this.

Comment 5

[Johann Hofmann [:johannh]]

As discussed I'll finish this bug

Comment 6

[Johann Hofmann [:johannh]]

Attachment: Only display permission prompts when they are anchored to the right icon (bug 1296252)

Review commit: https://reviewboard.mozilla.org/r/78158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78158/

Comment 7

[Johann Hofmann [:johannh]]

Attachment: Bug 1296252 - Add tests for stacked permission anchors on PopupNotifications update.

Review commit: https://reviewboard.mozilla.org/r/78160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78160/

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 8782399 [details]
Only display permission prompts when they are anchored to the right icon (bug 1296252).

https://reviewboard.mozilla.org/r/72588/#review76700

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8790252 [details]
Bug 1296252 - Add tests for stacked permission anchors on PopupNotifications update.

https://reviewboard.mozilla.org/r/78160/#review76906

Comment 10

[Johann Hofmann [:johannh]]

https://hg.mozilla.org/projects/elm/rev/aa24f94f9c9f2110dad763aeba414c3d2b4b28eb
Bug 1296252 - Only display permission prompts when they are anchored to the right icon. r=johannh

https://hg.mozilla.org/projects/elm/rev/517b890661a031030928171d777802653f031811
Bug 1296252 - Add tests for stacked permission anchors on PopupNotifications update. r=past

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8782399 [details]
Only display permission prompts when they are anchored to the right icon (bug 1296252).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72588/diff/1-2/

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

Posted a rebased version of the patch on top of fx-team tip, bug 1004061 and bug 1267604.

Comment 13

[:Paolo Amadini]

Attachment: Bug 1296252 - Part 1 - Only display doorhanger notifications when they are anchored to the right icon.

Review commit: https://reviewboard.mozilla.org/r/94264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94264/

Comment 14

[:Paolo Amadini]

Attachment: Bug 1296252 - Part 2 - Verify that doorhanger notifications are never shown together.

Review commit: https://reviewboard.mozilla.org/r/94266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94266/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff5425b88b3c
Part 1 - Only display doorhanger notifications when they are anchored to the right icon. r=johannh
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f3aa76aa619
Part 2 - Verify that doorhanger notifications are never shown together. r=past

Comment 16

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8812585 [details]
Bug 1296252 - Part 2 - Verify that doorhanger notifications are never shown together.

https://reviewboard.mozilla.org/r/94266/#review94510

Comment 17

[Johann Hofmann [:johannh]]

Comment on attachment 8812584 [details]
Bug 1296252 - Part 1 - Only display doorhanger notifications when they are anchored to the right icon.

https://reviewboard.mozilla.org/r/94264/#review94548

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ff5425b88b3c
https://hg.mozilla.org/mozilla-central/rev/9f3aa76aa619

Comment 19

[Md.Tarikul Islam Oashi]

I have to reproduced this bug with Nightly 51.0a1 on Windows 7 64 bit;

The Bug's fix is verified on Latest Nightly 

Build ID 	20170104030214
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20170104]

Comment 20

[Mihai Boldan, Desktop QA [:mboldan]]

Thanks Md.Tarikul Islam Oashi for helping us with this bugs.
I've also tested this issue on Mac OS X 10.12.1 and under Ubuntu 14.04x64.
I'm marking this bug Verified-Fixed.