Closed Bug 1296252 Opened 3 years ago Closed 3 years ago

Permission notifications with different anchors are stacked together on Elm

Categories

(Firefox :: Site Identity, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 53
Iteration:
51.2 - Aug 29
Tracking Status
firefox51 --- unaffected
firefox53 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

Details

(Whiteboard: [fxprivacy] [landed-on-elm])

Attachments

(5 files, 1 obsolete file)

See screenshot. I found two ways to trigger this so far (on Elm only!):

- go to https://permission.site/
- click on "Notifications" and "Location" without using the doorhangers
- navigate to a new tab
- close the new tab
- observe

and

- go to https://permission.site/
- click on "Camera" and "Location" without using the doorhanger
- click on "Notifications" and cancel the doorhanger by clicking the [x]
- observe

These shouldn't be grouped together since they belong to different anchors. Also, the stacking looks broken, but that will probably be handled in different bugs.
I think the stacking happens in nightly as well, only vertically and it looks nicer since different heights don't affect it. I can't remember how to reproduce it there, but the anchoring problem should be the same. My guess is that the horizontal stacking changed in bug 1267604 (but it may even be from bug 1004061).
This patch works, but needs a test.
Assignee: nobody → past
Status: NEW → ASSIGNED
Component: General → Device Permissions
Iteration: --- → 51.2 - Aug 29
Priority: -- → P1
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Component: Device Permissions → Site Identity and Permission Panels
Flags: qe-verify?
I would say that verification is not strictly necessary in this case, as this is something that will land on elm. The comprehensive QA effort after the merge to m-c will cover this.
Flags: qe-verify? → qe-verify-
As discussed I'll finish this bug
Assignee: past → jhofmann
Attachment #8790251 - Attachment is obsolete: true
Comment on attachment 8782399 [details]
Only display permission prompts when they are anchored to the right icon (bug 1296252).

https://reviewboard.mozilla.org/r/72588/#review76700
Attachment #8782399 - Flags: review?(jhofmann) → review+
Comment on attachment 8790252 [details]
Bug 1296252 - Add tests for stacked permission anchors on PopupNotifications update.

https://reviewboard.mozilla.org/r/78160/#review76906
Attachment #8790252 - Flags: review?(past) → review+
https://hg.mozilla.org/projects/elm/rev/aa24f94f9c9f2110dad763aeba414c3d2b4b28eb
Bug 1296252 - Only display permission prompts when they are anchored to the right icon. r=johannh

https://hg.mozilla.org/projects/elm/rev/517b890661a031030928171d777802653f031811
Bug 1296252 - Add tests for stacked permission anchors on PopupNotifications update. r=past
Whiteboard: [fxprivacy] → [fxprivacy] [landed-on-elm]
Posted a rebased version of the patch on top of fx-team tip, bug 1004061 and bug 1267604.
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff5425b88b3c
Part 1 - Only display doorhanger notifications when they are anchored to the right icon. r=johannh
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f3aa76aa619
Part 2 - Verify that doorhanger notifications are never shown together. r=past
Comment on attachment 8812585 [details]
Bug 1296252 - Part 2 - Verify that doorhanger notifications are never shown together.

https://reviewboard.mozilla.org/r/94266/#review94510
Attachment #8812585 - Flags: review?(past) → review+
Comment on attachment 8812584 [details]
Bug 1296252 - Part 1 - Only display doorhanger notifications when they are anchored to the right icon.

https://reviewboard.mozilla.org/r/94264/#review94548
Attachment #8812584 - Flags: review?(jhofmann) → review+
https://hg.mozilla.org/mozilla-central/rev/ff5425b88b3c
https://hg.mozilla.org/mozilla-central/rev/9f3aa76aa619
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
I have to reproduced this bug with Nightly 51.0a1 on Windows 7 64 bit;

The Bug's fix is verified on Latest Nightly 

Build ID 	20170104030214
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20170104]
Thanks Md.Tarikul Islam Oashi for helping us with this bugs.
I've also tested this issue on Mac OS X 10.12.1 and under Ubuntu 14.04x64.
I'm marking this bug Verified-Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.