1296286 - [Static Analysis][Resource leak] In function Base64DecodeHelper

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that a resource leak may happen in the following context:

>>  if (!PL_Base64Decode(aBase64, aBase64Len, aBinary)) {
>>    return NS_ERROR_INVALID_ARG;
>>  } 

This could be true only if |aBinary| is null and decode fails:

>>    status = decode((const unsigned char *)src, srclen, (unsigned char *)dest);
>>    if( PR_SUCCESS != status )
>>    {
>>        if( PR_TRUE == allocated )
>>        {
>>            PR_DELETE(dest);
>>        }
>>
>>        return (char *)0;
>>    }

In our case aBinary is never passed as null but though in order to silence this checker we should add a MOZ_ASSERT before the call of PL_Base64Decode

Comment 1

[Andi [:andi]]

Attachment: Bug 1296286 - preventfalse positive resource leak trigger in Base64DecodeHelper.

Review commit: https://reviewboard.mozilla.org/r/72618/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72618/

Comment 2

[Andi [:andi]]

Just to clear something up: decoder should NOT fail in order to have the leak.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8782443 [details]
Bug 1296286 - preventfalse positive resource leak trigger in Base64DecodeHelper.

https://reviewboard.mozilla.org/r/72618/#review70296

Sure.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe2f3a5598cc
preventfalse positive resource leak trigger in Base64DecodeHelper. r=froydnj

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fe2f3a5598cc