Closed Bug 1296335 Opened 3 years ago Closed 3 years ago

Do not extract gradle into $topsrcdir/gradle

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(3 files)

In automation we extract the gradle distribution into $topsrcdir/gradle (and rm before). However we have the gradle wrapper files in gradle/ already and therefore modify the checkout (effectively removing the wrapper files). This is particularly annoying if we want to work with the checkout later (see bug 1287643).
The idea is to:

* Use a different name for the gradle archive (maybe gradle-dist) so that it will extract to a different folder (modify after.sh).
* Upload the new archive to tooltool
* Replace the digest in the releng.manifest files
* Modify the --with-gradle option in the mozconfig files used in automation
* Watch the world burn
Blocks: 1296146
No longer blocks: 1287643
Comment on attachment 8782989 [details]
Bug 1296335 - Update releng.manifest files to point to new gradle archive.

https://reviewboard.mozilla.org/r/72982/#review70736

stamp
Attachment #8782989 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8782990 [details]
Bug 1296335 - Update android-api-15-* mozconfig files to point to new gradle folder.

https://reviewboard.mozilla.org/r/72984/#review70738
Attachment #8782990 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8782988 [details]
Bug 1296335 - after.sh: Package gradle binaries as gradle-dist.tar.xz.

https://reviewboard.mozilla.org/r/72980/#review70734
Attachment #8782988 - Flags: review?(bugspam.Callek) → review+
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/57421ca272a2
after.sh: Package gradle binaries as gradle-dist.tar.xz. r=Callek
https://hg.mozilla.org/integration/autoland/rev/30b037e0fd1d
Update releng.manifest files to point to new gradle archive. r=Callek
https://hg.mozilla.org/integration/autoland/rev/dc16d1edec70
Update android-api-15-* mozconfig files to point to new gradle folder. r=Callek
https://hg.mozilla.org/mozilla-central/rev/57421ca272a2
https://hg.mozilla.org/mozilla-central/rev/30b037e0fd1d
https://hg.mozilla.org/mozilla-central/rev/dc16d1edec70
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 51 → mozilla51
You need to log in before you can comment on or make changes to this bug.