1296335 - Do not extract gradle into $topsrcdir/gradle

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

In automation we extract the gradle distribution into $topsrcdir/gradle (and rm before). However we have the gradle wrapper files in gradle/ already and therefore modify the checkout (effectively removing the wrapper files). This is particularly annoying if we want to work with the checkout later (see bug 1287643).

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

The idea is to:

* Use a different name for the gradle archive (maybe gradle-dist) so that it will extract to a different folder (modify after.sh).
* Upload the new archive to tooltool
* Replace the digest in the releng.manifest files
* Modify the --with-gradle option in the mozconfig files used in automation
* Watch the world burn

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=144abfa465a9

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=88d69ceb41bb

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1296335 - after.sh: Package gradle binaries as gradle-dist.tar.xz.

Review commit: https://reviewboard.mozilla.org/r/72980/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72980/

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1296335 - Update releng.manifest files to point to new gradle archive.

Review commit: https://reviewboard.mozilla.org/r/72982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72982/

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1296335 - Update android-api-15-* mozconfig files to point to new gradle folder.

Review commit: https://reviewboard.mozilla.org/r/72984/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72984/

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8782989 [details]
Bug 1296335 - Update releng.manifest files to point to new gradle archive.

https://reviewboard.mozilla.org/r/72982/#review70736

stamp

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 8782990 [details]
Bug 1296335 - Update android-api-15-* mozconfig files to point to new gradle folder.

https://reviewboard.mozilla.org/r/72984/#review70738

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 8782988 [details]
Bug 1296335 - after.sh: Package gradle binaries as gradle-dist.tar.xz.

https://reviewboard.mozilla.org/r/72980/#review70734

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57421ca272a2
after.sh: Package gradle binaries as gradle-dist.tar.xz. r=Callek
https://hg.mozilla.org/integration/autoland/rev/30b037e0fd1d
Update releng.manifest files to point to new gradle archive. r=Callek
https://hg.mozilla.org/integration/autoland/rev/dc16d1edec70
Update android-api-15-* mozconfig files to point to new gradle folder. r=Callek

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/57421ca272a2
https://hg.mozilla.org/mozilla-central/rev/30b037e0fd1d
https://hg.mozilla.org/mozilla-central/rev/dc16d1edec70