Do not extract gradle into $topsrcdir/gradle

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sebastian, Assigned: sebastian)

Tracking

unspecified
Firefox 51
All
Android
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
In automation we extract the gradle distribution into $topsrcdir/gradle (and rm before). However we have the gradle wrapper files in gradle/ already and therefore modify the checkout (effectively removing the wrapper files). This is particularly annoying if we want to work with the checkout later (see bug 1287643).
(Assignee)

Comment 1

2 years ago
The idea is to:

* Use a different name for the gradle archive (maybe gradle-dist) so that it will extract to a different folder (modify after.sh).
* Upload the new archive to tooltool
* Replace the digest in the releng.manifest files
* Modify the --with-gradle option in the mozconfig files used in automation
* Watch the world burn
(Assignee)

Updated

2 years ago
Blocks: 1296146
No longer blocks: 1287643
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8782989 [details]
Bug 1296335 - Update releng.manifest files to point to new gradle archive.

https://reviewboard.mozilla.org/r/72982/#review70736

stamp
Attachment #8782989 - Flags: review?(bugspam.Callek) → review+

Comment 8

2 years ago
mozreview-review
Comment on attachment 8782990 [details]
Bug 1296335 - Update android-api-15-* mozconfig files to point to new gradle folder.

https://reviewboard.mozilla.org/r/72984/#review70738
Attachment #8782990 - Flags: review?(bugspam.Callek) → review+

Comment 9

2 years ago
mozreview-review
Comment on attachment 8782988 [details]
Bug 1296335 - after.sh: Package gradle binaries as gradle-dist.tar.xz.

https://reviewboard.mozilla.org/r/72980/#review70734
Attachment #8782988 - Flags: review?(bugspam.Callek) → review+

Comment 10

2 years ago
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/57421ca272a2
after.sh: Package gradle binaries as gradle-dist.tar.xz. r=Callek
https://hg.mozilla.org/integration/autoland/rev/30b037e0fd1d
Update releng.manifest files to point to new gradle archive. r=Callek
https://hg.mozilla.org/integration/autoland/rev/dc16d1edec70
Update android-api-15-* mozconfig files to point to new gradle folder. r=Callek

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/57421ca272a2
https://hg.mozilla.org/mozilla-central/rev/30b037e0fd1d
https://hg.mozilla.org/mozilla-central/rev/dc16d1edec70
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.