1296344 - Active tab shows gray shade after deactivating High-Contrast theme

Status: NEW

(Core :: Graphics: ImageLib, defect, P3)

Description

[Azmina]

Attachment: attachment.PNG

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce:

User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID : 20160818030226


Steps to reproduce :

1. Select and activate the High-Contrast theme in Windows.
2. Open Firefox.
3. Deactivate the High-Contrast theme in Windows.


Actual results:

Actual Result:

There is grey shade on two side of the active tab (see the attached screenshot).


Expected results:

Expected Result:

There should not be any grey shade on the active tab.

Comment 1

[Azmina]

Sorry for Messing up the User Story, giving it again below

https://bug1296344.bmoattachments.org/attachment.cgi?id=8782511

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce :
1. Select and activate the High-Contrast theme in Windows.
2. Open Firefox.
3. Deactivate the High-Contrast theme in Windows.

Actual Result :
There is grey shade on two side of the active tab (see the attached screenshot).

Expected Result :
There should not be any grey shade on the active tab.

Comment 2

[Hossain Al Ikram [:ikram] (QA Contact)]

Moved to a better component, To have more insights. Please change, If there is a better component!

Comment 3

[:Gijs (out for now; he/him)]

I thought this was supposed to be fixed by bug 940625. jwatt is out and seth left. Matt, do you remember how this is supposed to work?

Comment 4

[Loic]

In general, on Windows, you need to restart Firefox after changing the OS theme, because the Firefox UI is completely "broken".

Comment 5

[Matthew N. [:MattN]]

(In reply to :Gijs Kruitbosch from comment #3)
> I thought this was supposed to be fixed by bug 940625. jwatt is out and seth
> left. Matt, do you remember how this is supposed to work?

I'm not sure what you're asking since the patch in that bug is pretty straightforward to understand.

It seems like finding out whether bug 940625 ever worked on that OS version and if so, getting a regression range would be most useful.

http://mozilla.github.com/mozregression is the tool to use to test old builds.

Comment 6

[Justin [:JW_SoftvisionQA]]

I got this regression range from running MozRegression

Last good revision: 152ef25e89ae (2014-09-10)
First bad revision: 98ea98c8191a (2014-09-11)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=152ef25e89ae&tochange=98ea98c8191a

Comment 7

[:Gijs (out for now; he/him)]

(In reply to Justin [:JW_SoftvisionQA] from comment #6)
> I got this regression range from running MozRegression
> 
> Last good revision: 152ef25e89ae (2014-09-10)
> First bad revision: 98ea98c8191a (2014-09-11)
> Pushlog:
> https://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=152ef25e89ae&tochange=98ea98c8191a

I've looked at this window and I can't for the life of me see any changes that look like they'd be directly related to this behaviour.

Then I tested the builds and afaict they're both broken. I also then checked the build for June 27 and June 26 on Windows and the corners of the tabs are broken there, too. So to the best of my knowledge it just never worked - at least, I don't see this working on Windows 10. I'll try on windows 7 later.

Comment 8

[:Gijs (out for now; he/him)]

(In reply to :Gijs Kruitbosch from comment #7)
> (In reply to Justin [:JW_SoftvisionQA] from comment #6)
> > I got this regression range from running MozRegression
> > 
> > Last good revision: 152ef25e89ae (2014-09-10)
> > First bad revision: 98ea98c8191a (2014-09-11)
> > Pushlog:
> > https://hg.mozilla.org/mozilla-central/
> > pushloghtml?fromchange=152ef25e89ae&tochange=98ea98c8191a
> 
> I've looked at this window and I can't for the life of me see any changes
> that look like they'd be directly related to this behaviour.
> 
> Then I tested the builds and afaict they're both broken. I also then checked
> the build for June 27 and June 26 on Windows and the corners of the tabs are
> broken there, too. So to the best of my knowledge it just never worked - at
> least, I don't see this working on Windows 10. I'll try on windows 7 later.

Doesn't work with the June 26 build on my win7 vm either (switching from aero to classic).

Not sure if this is just us not getting a notification from windows or us not doing enough with the notification, but either way, it doesn't work. I suspect the culprit is still (somehow) imagelib/svg, though, because the colors of the titlebar etc. do change. Though actually, to be fair, content loaded in tabs doesn't get thoroughly updated either, so it could also be a widget/ issue? Up to whoever investigates further. :-\

TBH, not clear that investigating this any further should be a real priority. While I'm sure it's theoretically fixable, a simple restart solves this and the switches are very uncommon in practice.