Closed Bug 1296361 Opened 5 years ago Closed 5 years ago

Implement shadow behind arrow panels across platforms

Categories

(Toolkit :: Themes, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch arrow-popup-shadow.diff (obsolete) — Splinter Review
We currently don't have a shadow on Linux (because of bug 408284) and non-default Windows themes.
Attachment #8782538 - Flags: review?(mdeboer)
Dão, I assume the way to test this is to apply this patch on Linux & Windows and see if the drop-shadow is applied and cast on the background?
Flags: needinfo?(dao+bmo)
(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Dão, I assume the way to test this is to apply this patch on Linux & Windows
> and see if the drop-shadow is applied and cast on the background?

yep
Flags: needinfo?(dao+bmo)
Comment on attachment 8782538 [details] [diff] [review]
arrow-popup-shadow.diff

Review of attachment 8782538 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Dão! (I can't think of a reason why shorlander would need to ui-r this, but flag him if you can think of one!)
Attachment #8782538 - Flags: review?(mdeboer) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec5af78d53a3
Implement shadow behind arrow panels across platforms. r=mdeboer
(In reply to Dão Gottwald [:dao] from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/d655d1c3e529
> 
> Backed out because of test_arrowpanel.xul failure:
> https://treeherder.mozilla.org/logviewer.html#?job_id=34423474&repo=mozilla-
> inbound#L4528

Neil, is this another failure like the one from bug 961727 comment 1? What magic number or string do I need to modify to fix this?
Flags: needinfo?(enndeakin)
I'm kind of poking in the dark here, but I think this fixes the failure.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=69e92d28b2a3
Attachment #8782538 - Attachment is obsolete: true
Flags: needinfo?(enndeakin)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfc2a69bb100
Implement shadow behind arrow panels across platforms. r=mdeboer
https://hg.mozilla.org/mozilla-central/rev/dfc2a69bb100
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(In reply to Matthew N. [:MattN] from comment #10)
> Was I supposed to see a change on Windows?

Only with non-default Windows themes.
Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.