1296361 - Implement shadow behind arrow panels across platforms

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P3)

Description

[Dão Gottwald [:dao]]

Attachment: arrow-popup-shadow.diff

We currently don't have a shadow on Linux (because of bug 408284) and non-default Windows themes.

Comment 1

[Mike de Boer [:mikedeboer]]

Dão, I assume the way to test this is to apply this patch on Linux & Windows and see if the drop-shadow is applied and cast on the background?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Dão, I assume the way to test this is to apply this patch on Linux & Windows
> and see if the drop-shadow is applied and cast on the background?

yep

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8782538 [details] [diff] [review]
arrow-popup-shadow.diff

Review of attachment 8782538 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Dão! (I can't think of a reason why shorlander would need to ui-r this, but flag him if you can think of one!)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec5af78d53a3
Implement shadow behind arrow panels across platforms. r=mdeboer

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d655d1c3e529

Backed out because of test_arrowpanel.xul failure: https://treeherder.mozilla.org/logviewer.html#?job_id=34423474&repo=mozilla-inbound#L4528

Comment 6

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/d655d1c3e529
> 
> Backed out because of test_arrowpanel.xul failure:
> https://treeherder.mozilla.org/logviewer.html#?job_id=34423474&repo=mozilla-
> inbound#L4528

Neil, is this another failure like the one from bug 961727 comment 1? What magic number or string do I need to modify to fix this?

Comment 7

[Dão Gottwald [:dao]]

Attachment: arrow-popup-shadow.diff

I'm kind of poking in the dark here, but I think this fixes the failure.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=69e92d28b2a3

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfc2a69bb100
Implement shadow behind arrow panels across platforms. r=mdeboer

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dfc2a69bb100

Comment 10

[Matthew N. [:MattN]]

Was I supposed to see a change on Windows? I only see the new shadow on Linux panels: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=01748a2b1a463f24efd9cd8abad9ccfd76b037b8&newProject=mozilla-central&newRev=a551f534773cf2d6933f78ce7d82a7a33a99643e&filter=%5B%5Eo%5D%5B%5En%5D%24

Comment 11

[Dão Gottwald [:dao]]

(In reply to Matthew N. [:MattN] from comment #10)
> Was I supposed to see a change on Windows?

Only with non-default Windows themes.