Closed Bug 1296412 Opened 4 years ago Closed 4 years ago

remove last dependency on system.js

Categories

(DevTools :: Framework, enhancement, P1)

enhancement

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Iteration:
51.2 - Aug 29
Tracking Status
firefox51 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [reserve-html])

Attachments

(1 file)

Experimenting with webpack shows just a single inclusion of system.js from
the inspector.  This is easily removed and reduces both the size of the pack
and the number of other modules we have to fix up.
Iteration: --- → 51.2 - Aug 29
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
Comment on attachment 8782607 [details]
Bug 1296412 - use System.appinfo, not services.js, in inspector;

https://reviewboard.mozilla.org/r/72710/#review70790

Looks good to me
Attachment #8782607 - Flags: review?(bgrinstead) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f3459b7c54a
use System.appinfo, not services.js, in inspector; r=bgrins
https://hg.mozilla.org/mozilla-central/rev/3f3459b7c54a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.