1296472 - Update Application Reputation Protobuf file

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[François Marier [:francois]]

The protobuf file we are using for Application Reputation is a little old and needs to be sync'ed with the Chromium one.

Comment 1

[François Marier [:francois]]

Attachment: Bug 1296472 - Move upstream chromium code into chromium directory.

Review commit: https://reviewboard.mozilla.org/r/72748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72748/

Comment 2

[François Marier [:francois]]

Attachment: Bug 1296472 - Update the bug component for Application Reputation files.

Review commit: https://reviewboard.mozilla.org/r/72750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72750/

Comment 3

[François Marier [:francois]]

Attachment: Bug 1296472 - Update csd.proto to the latest upstream version.

Review commit: https://reviewboard.mozilla.org/r/72752/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72752/

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8782682 [details]
Bug 1296472 - Move upstream chromium code into chromium directory.

https://reviewboard.mozilla.org/r/72748/#review70566

::: toolkit/components/downloads/chromium/LICENSE:12
(Diff revision 1)
> +//    * Redistributions of source code must retain the above copyright
> +// notice, this list of conditions and the following disclaimer.
> +//    * Redistributions in binary form must reproduce the above
> +// copyright notice, this list of conditions and the following disclaimer
> +// in the documentation and/or other materials provided with the
> +// distribution.

about:license#chromium

Chromium License

This license applies to parts of the code in security/sandbox/, editor/libeditor/nsEditorEventListener.cpp, widget/cocoa/GfxInfo.mm and also some files in the directories ipc/chromium/, dom/plugins/, tools/profiler/, gfx/ots/, media/openmax_dl/, gfx/ycbcr and dom/media/webspeech/recognition/. 

This needs an update.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8782683 [details]
Bug 1296472 - Update the bug component for Application Reputation files.

https://reviewboard.mozilla.org/r/72750/#review70568

Comment 6

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8782684 [details]
Bug 1296472 - Update csd.proto to the latest upstream version.

https://reviewboard.mozilla.org/r/72752/#review70570

rs+ more than r+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52dac873d077
Move upstream chromium code into chromium directory. r=gcp
https://hg.mozilla.org/integration/autoland/rev/d341ddd2356a
Update the bug component for Application Reputation files. r=gcp
https://hg.mozilla.org/integration/autoland/rev/545aaf3d17f4
Update csd.proto to the latest upstream version. r=gcp

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/52dac873d077
https://hg.mozilla.org/mozilla-central/rev/d341ddd2356a
https://hg.mozilla.org/mozilla-central/rev/545aaf3d17f4