Closed Bug 1296507 Opened 8 years ago Closed 7 years ago

password and control center doorhangers janky when closing under OSX

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Version:
51 Branch
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox51 --- affected

People

(Reporter: kjozwiak, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qx:p-] [fxprivacy]) 

From bug#1252224comment#52
> I've noticed that the password manager and control center doorhangers are
> really janky during transitions when pressing the "ESC" key [1]. Pressing
> the "X" rather than using the "ESC" key closes the doorhanger without any of
> the jank/sluggish transitions/animations. I'm only seeing this happen under
> macOS 10.11.6 and doesn't look like it's happening under the Win 10/Ubuntu
> VM's.
> 
> Is what I'm seeing related to this bug? Or does it warrant a separate bug?
> 
> [1] https://youtu.be/OZVMX05tRQk

This is happening with all versions of fx under macOS. I'm not sure if it's just my MBP (which is pretty new), or if there was a macOS update that made closing the menu's look really janky, but it's definitely not happening under Win 10 x64.

Let me know if there's anything else that I can provide, perhaps a profile using the Cleopatra add-on?
It looks like it's actually taking a different code path for the X button versus ESC key. One might trigger an animation whereas the other is hiding the panel immediately.
Panos - you want to look at this as part of the notification / control center work?
Flags: needinfo?(past)
Whiteboard: [qx:p-]
Yes, thanks for the ping. We will triage it at our next meeting.
Flags: needinfo?(past)
Whiteboard: [qx:p-] → [qx:p-][fxprivacy][triage]
Priority: -- → P2
Whiteboard: [qx:p-][fxprivacy][triage] → [qx:p-][fxprivacy]
Whiteboard: [qx:p-][fxprivacy] → [photon] [qx:p-] [fxprivacy]
Depends on: 1291457
Kamil, can you please check if this is fixed in 53 with the new doorhangers?
Flags: needinfo?(kjozwiak)
Whiteboard: [photon] [qx:p-] [fxprivacy] → [photon-visual] [qx:p-] [fxprivacy]
Flags: qe-verify+
QA Contact: ovidiu.boca
(In reply to Johann Hofmann [:johannh] from comment #4)
> Kamil, can you please check if this is fixed in 53 with the new doorhangers?

The janky/sluggish behaviour is still happening with the new doorhangers in fx53. When dismissing the doorhanger via "ESC" or clicking anywhere on the current page, you'll notice that the transition/animation doesn't look really smooth. However, clicking on either the "Don't Save", "Save" or "Never Save" buttons will close the doorhanger instantly without any animation jank.

Quick example of the issue with the new doorhangers (hopefully you can see the jank): https://youtu.be/918KqFboJO8

Build used:
* fx53.0, buildid: 20170411024320, changeset: afa44b2ebb35
Flags: needinfo?(kjozwiak)
QA Contact: ovidiu.boca → brindusa.tot
Blocks: photon-performance-triage
Whiteboard: [photon-visual] [qx:p-] [fxprivacy] → [photon-performance] [qx:p-] [fxprivacy]
QA Contact: brindusa.tot → adrian.florinescu
Priority: P2 → P3
Whiteboard: [photon-performance] [qx:p-] [fxprivacy] → [reserve-photon-performance] [qx:p-] [fxprivacy]
I believe this is now fixed after bug 1291457 landed. Please reopen if you still see jank.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Flags: qe-verify+
Priority: P3 → --
QA Contact: adrian.florinescu
Whiteboard: [reserve-photon-performance] [qx:p-] [fxprivacy] → [qx:p-] [fxprivacy]
You need to log in before you can comment on or make changes to this bug.