1296524 - Firefox crashes while browsing/scrolling webpages

Status: VERIFIED FIXED

(Firefox :: Untriaged, defect)

Description

[RAHUL BHAGWAT]

Attachment: firefox_crash_backtraces

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36

Steps to reproduce:

Load any webpage(I tried nytimes.com) and scroll the page. 

Platform: arm64, linux

Attaching bracktrace of crash and backtrace of suspected function which is causing crash.


Actual results:

In few moment firefox crashes


Expected results:

Firefox should not crash

Comment 1

[RAHUL BHAGWAT]

Platform is amr64 linux

Comment 2

[George Wright (:gw280) (needinfo me!)]

This is because we don't enable MOZ_ENABLE_SKIA on aarch64: https://dxr.mozilla.org/mozilla-central/source/old-configure.in#5245

The simplest fix here might be to only add the Skia BackendType to the canvasMask here when USE_SKIA is set: https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxPlatform.cpp?q=gfxPlatform.cpp&redirect_type=direct#504

Comment 3

[George Wright (:gw280) (needinfo me!)]

Attachment: 0001-Bug-1296524-Don-t-add-Skia-to-the-allowable-canvas-t.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ed0fb296e50
Don't add Skia to the allowable canvas types unless USE_SKIA is defined r=mchang

Comment 5

[George Wright (:gw280) (needinfo me!)]

Rahul, can you confirm that this patch fixes your issue?

Comment 6

[RAHUL BHAGWAT]

Issue seems fixed at my side. I've tested the patch on arm64 linux platform.
It would be great if this patch is submitted to v48 so that we can use current released firefox on arm64 platforms.

Comment 7

[RAHUL BHAGWAT]

I tested on firefox v48.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ed0fb296e50

Comment 9

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8783353 [details] [diff] [review]
0001-Bug-1296524-Don-t-add-Skia-to-the-allowable-canvas-t.patch

Approval Request Comment
[Feature/regressing bug #]: 1296524
[User impact if declined]: certain (non-tier1) platforms will crash reliably and often when using the browser
[Describe test coverage new/current, TreeHerder]: current tests are fine; wasn't caught by test infrastructure as it doesn't affect platforms we officially support and test on.
[Risks and why]: very low risk, only changes platforms which USE_SKIA is not defined on which is none of our tier 1s.
[String/UUID change made/needed]: none

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8783353 [details] [diff] [review]
0001-Bug-1296524-Don-t-add-Skia-to-the-allowable-canvas-t.patch

Fixes a severe crash, fix was verified on try push by bug filer (I think), Aurora50+

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8783353 [details] [diff] [review]
0001-Bug-1296524-Don-t-add-Skia-to-the-allowable-canvas-t.patch

Review of attachment 8783353 [details] [diff] [review]:
-----------------------------------------------------------------

This patch fixes a crash. Take it in 49 beta.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Do we have some crash id to evaluate the impact? thanks

Comment 13

[George Wright (:gw280) (needinfo me!)]

Rahul, do you have any crash reports for this issue? about:crashes will show you recently submitted crash reports.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1498a3c2f15c

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f4870f71d0b5

Comment 16

[RAHUL BHAGWAT]

I reproduced the crash but I could not get crash report when type about:crashes in both normal and safe mode, pages display message  "The address isn't valid".
But I've already uploaded backtrace of crash in this bug.

Comment 17

[RAHUL BHAGWAT]

May I know in which release the fix will be available?

Comment 18

[RAHUL BHAGWAT]

I’ve tested forefox v49, still I’m getting crash but this time whole browser does not crash, only tab crashes.

Comment 19

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Rahul, based on the commit dates, this fix has shipped in Release Fx49 version. 

Hi George, can you please investigate Rahul's comment that this crash may not really be fixed in Fx49? Thanks!

Comment 20

[George Wright (:gw280) (needinfo me!)]

Rahul, do you have a backtrace?

Comment 21

[Surentharan]

[bugday-20170125]

Comment 22

[Surentharan]

[bugday-20170125] OS:Windows 8.1, I gone through the website nytimes.com . and its works correctly, the bug has been fixed