1296578 - [e10s] TextInputHandler should use query events relative to insertion point during composition

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

When I type fast and start composition before widget receives selection change notification, candidate window is positioned at prior character of composition string.

I think that TextInputHandler should use query events relative to insertion point during composition.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8373b328b57d

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1296578 IMEInputHandler should use insertion point relative query content events during composition

Start offset of composition string is fixed when composition string becomes non-empty in focused editor. In other words, until composition string is fixed, composition start offset may be changed from selection start offset at dispatching compositionstart event.  Especially, in e10s mode, pending keyboard events usually change composition start offset.

So, while there is composition, IMEHandler should use query events querying text rect or text content relative to actual start offset of composition string because native IME believes composition string at selection selection start when starting composition in the main process.

Review commit: https://reviewboard.mozilla.org/r/73112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73112/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8783238 [details]
Bug 1296578 IMEInputHandler should use insertion point relative query content events during composition

https://reviewboard.mozilla.org/r/73112/#review70942

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8783238 [details]
Bug 1296578 IMEInputHandler should use insertion point relative query content events during composition

https://reviewboard.mozilla.org/r/73112/#review70944

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d16d42082abf
IMEInputHandler should use insertion point relative query content events during composition r=m_kato

Comment 6

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/d16d42082abf