1296579 - Remove the SimplePush API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gabriele Svelto [:gsvelto]]

+++ This bug was initially created as a clone of Bug #1291291 +++

This can be split out of bug 1291291; since the API is deprecated and replaced by Push we can remove it right away.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: [PATCH] Remove the SimplePush API

I've tried to carefully remove all traces from the code, including comments. The try run is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec7843162fa2

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: [PATCH] Remove the SimplePush API

Refreshed patch. This removes the SimplePush API and all the conditional bits that were peppered around the code to accommodate for it as an alternative to standard Push. The try run is here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=617e010dea93

Comment 3

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8784299 [details] [diff] [review]
[PATCH] Remove the SimplePush API

Redirecting the review since I assume Doug won't be available to do it.

Comment 4

[Lina Butler [:lina]]

Comment on attachment 8784299 [details] [diff] [review]
[PATCH] Remove the SimplePush API

Looks good, very thorough!

The WebIDL changes need DOM peer review, too. Baku, could you have a look, please?

Comment 5

[Gabriele Svelto [:gsvelto]]

Thank you both for the quick review! I've refreshed the patch (it had slightly bit-rotted) and pushed to try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6294693127b&selectedJob=26618488

It's looking good save for the usual orange. I've re-triggered some of the failed tests and will be waiting for it to be completely green before landing. I've also shot an e-mail to dev-platform to inform of the change.

(In reply to Kit Cambridge [:kitcambridge] from comment #4)
> Looks good, very thorough!

Yeah, I wanted to make sure we had no leftovers to avoid confusion with standard Push. Besides simplifying this code should help me and the other volunteers to enable the real Push API on B2G soon enough.

Comment 6

[Lina Butler [:lina]]

(In reply to Gabriele Svelto [:gsvelto] from comment #5)
> Besides simplifying this code should help me and the other
> volunteers to enable the real Push API on B2G soon enough.

That's awesome!

Comment 7

[Gabriele Svelto [:gsvelto]]

I've refreshed the patch and I'm ready to land, the try run is here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f5afb944870

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e2ee40eaefc
Remove the SimplePush API r=kitcambridge,baku

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e2ee40eaefc

Comment 10

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/non-standard-simple-push-api-has-been-removed/

Comment 11

[Gabriele Svelto [:gsvelto]]

(In reply to Kohei Yoshino [:kohei] from comment #10)
> Posted the site compatibility doc:
> https://www.fxsitecompat.com/en-CA/docs/2016/non-standard-simple-push-api-
> has-been-removed/

Thanks!

Comment 12

[Chris Mills [:cmills]]

Actions:

Navigator.push removed from the main doc tree, and moved to the FirefoxOS APIs archive:

https://developer.mozilla.org/en-US/docs/Web/API/Navigator
https://developer.mozilla.org/en-US/docs/Archive/Firefox_OS/API/Navigator
https://developer.mozilla.org/en-US/docs/Archive/Firefox_OS/API/Navigator/push
https://developer.mozilla.org/en-US/docs/Archive/Firefox_OS/API/Simple_Push_API

Firefox 51 release notes updated with a note:

https://developer.mozilla.org/en-US/Firefox/Releases/51#DOM_HTML_DOM

Let me know if you think anything else needs to be done. Thanks!