Closed Bug 1296579 Opened 8 years ago Closed 8 years ago

Remove the SimplePush API

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1291291 +++

This can be split out of bug 1291291; since the API is deprecated and replaced by Push we can remove it right away.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
I've tried to carefully remove all traces from the code, including comments. The try run is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec7843162fa2
Refreshed patch. This removes the SimplePush API and all the conditional bits that were peppered around the code to accommodate for it as an alternative to standard Push. The try run is here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=617e010dea93
Attachment #8782887 - Attachment is obsolete: true
Attachment #8784299 - Flags: review?(doug.turner)
Comment on attachment 8784299 [details] [diff] [review]
[PATCH] Remove the SimplePush API

Redirecting the review since I assume Doug won't be available to do it.
Attachment #8784299 - Flags: review?(doug.turner) → review?(kcambridge)
Comment on attachment 8784299 [details] [diff] [review]
[PATCH] Remove the SimplePush API

Looks good, very thorough!

The WebIDL changes need DOM peer review, too. Baku, could you have a look, please?
Attachment #8784299 - Flags: review?(kcambridge) → review?(amarchesini)
Attachment #8784299 - Flags: review?(amarchesini) → review+
Thank you both for the quick review! I've refreshed the patch (it had slightly bit-rotted) and pushed to try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6294693127b&selectedJob=26618488

It's looking good save for the usual orange. I've re-triggered some of the failed tests and will be waiting for it to be completely green before landing. I've also shot an e-mail to dev-platform to inform of the change.

(In reply to Kit Cambridge [:kitcambridge] from comment #4)
> Looks good, very thorough!

Yeah, I wanted to make sure we had no leftovers to avoid confusion with standard Push. Besides simplifying this code should help me and the other volunteers to enable the real Push API on B2G soon enough.
(In reply to Gabriele Svelto [:gsvelto] from comment #5)
> Besides simplifying this code should help me and the other
> volunteers to enable the real Push API on B2G soon enough.

That's awesome!
I've refreshed the patch and I'm ready to land, the try run is here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f5afb944870
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e2ee40eaefc
Remove the SimplePush API r=kitcambridge,baku
https://hg.mozilla.org/mozilla-central/rev/4e2ee40eaefc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(In reply to Kohei Yoshino [:kohei] from comment #10)
> Posted the site compatibility doc:
> https://www.fxsitecompat.com/en-CA/docs/2016/non-standard-simple-push-api-
> has-been-removed/

Thanks!
Component: DOM → DOM: Core & HTML
See Also: → 1147274
You need to log in before you can comment on or make changes to this bug.