1296594 - stylo: Move Servo binding functions to a list file to reduce code duplication

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Currently, when adding a binding function which is implemented in the Servo side, we would need to add a declaration to ServoBindings.h and add a stub definition to ServoBindings.cpp with a MOZ_CRASH. Changing any of those functions would need changing both places as well, which is error-prone (especially given that the stub definitions in ServoBindings.cpp are only compiled with non-stylo built, so one may forget to change that until pushing to the CI system).

We can move all those binding functions into a unified list file, and use macro to generate the declarations and definitions.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1296594 - Move Servo binding functions to a list file.

Review commit: https://reviewboard.mozilla.org/r/72886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72886/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

The Servo side change of this bug doesn't need to coordinate with this patch, as Servo doesn't really need the declarations it implements.

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8782856 [details]
Bug 1296594 - Move Servo binding functions to a list file.

https://reviewboard.mozilla.org/r/72886/#review70742

Nice.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/422bce8e5a41
Move Servo binding functions to a list file. r=bholley

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/422bce8e5a41