1296620 - Disco pane add-ons cannot replace unsigned add-ons installed via registry key

Status: REOPENED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: gif.gif

This is a follow-up bug for Bug 1294483
 
[Affected versions]:
Firefox 48.0.1 (20160817112116)
Firefox 49.0b5 (20160818050015)
Firefox 50.0a2 (2016-08-19)
Firefox 51.0a1 (2016-08-18)

[Affected platforms]:
Windows 10 32-bit
Windows 7 64-bit 

[Steps to reproduce]:
1.Find one of the 4 add-ons displayed in Disco Pane and remove its signature (e.g Video DownloadHelper).
2.Install the unsigned add-on via registry key
3.Launch Firefox with a clean profile.
4.Check in Addons Manager -> Extensions that the add-on is disabled.
5.Go to Add-ons Manager -> Get Add-ons and install the signed version of the add-on.

[Expected results]:
The signed add-on is successfully installed from disco pane and the unsigned one is replaced.

[Actual results]:
“Your add-on is ready” message is displayed but the add-on is not installed and the toggle button cannot be activated.
- I am attaching a video recorded on Windows 7 x64 where I captured this issue.

[Additional notes]:
- The signed add-on is successfully installed via drag&drop, “Install from file” or from addons.mozilla.org. The unsigned add-on is replaced by the signed one, but the registry key is not removed. The unsigned add-on is displayed again as disabled in Addons Manager after the signed add-on is removed.

Comment 1

[Andy McKay]

There's nothing in that suggests it should be a security bug, can we remove that flag?

Comment 2

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.