1296749 - Fix DirectX shutdown order

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

I'm still not sure exactly how I got this to manifest, or why it doesn't manifest normally, but the way we shutdown DirectX is backwards, and was crashing with the GPU process enabled.

Currently it's:
 * Release D3D11
 * Release D2D
 * Release reference draw target

It should be:
 * Release reference draw target
 * Release D2D
 * Release D3D11

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e25ef116964
Fix DirectX shutdown ordering issues. (bug 1296749, r=mattwoodrow)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7e25ef116964

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8783063 [details] [diff] [review]
patch

Approval Request Comment
This should have a positive impact on reducing crashes in (at least a percentage of) bug 1292311 and  bug 1285333.  The patch has been on 51 since August, so the risk of regressions is very low.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8783063 [details] [diff] [review]
patch

Fix has been on Nightly for a few weeks, should help improve stability, Beta50+

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9b8bac3cd9eb

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

From the bugs mentioned as affected, sounds like 49 is also affected here too. If this fixes the crash in bug 1292311 we could consider it for 49. 

Andrei, could your team help verify the crash fix on beta 50 once we have more data?

Comment 8

[Ciprian Georgiu, Desktop QA]

I tried to reproduce the crashes mentioned by Milan, in bug 1292311 and bug 1285333 with 49 on Windows 7 x86, but unfortunately, I didn't managed. 

David, is there a way I can manually verify this fixes? I am missing something?

Comment 9

[David Anderson [:dvander] - inactive, e-mail if emergency]

When I reproduced this crash, it was on a separate branch and I might have had the debug DirectX SDK installed. So I'm guessing it's not that easy to reproduce.

Comment 10

[Ciprian Georgiu, Desktop QA]

Thank you, David for your reply. I will remove Andrei's ni? since this issue is a bit complicated for manual verification.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

At this point I think we should stick with waiting for this fix to come along in 50.  Wontfix for 49.