Closed Bug 1296917 Opened 9 years ago Closed 8 years ago

Fix itemToggle icon url in shadereditor.css

Categories

(DevTools Graveyard :: WebGL Shader Editor, defect)

Product:
DevTools Graveyard
Component:
WebGL Shader Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox50 verified, firefox51 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox50 --- verified
firefox51 --- verified

People

(Reporter: magicp.jp, Assigned: ntim)

References

Details

Attachments

(2 files, 1 obsolete file)

Fix-itemToggle-icon-url-in-shadereditor.css.png
62.02 KB, image/png
Details
Fix erronous references to itemToggle.png
1.65 KB, patch
bgrins
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 Build ID: 20160820030224 Steps to reproduce: 1. Start Nightly 2. Go to "http://helloracer.com/webgl/" 3. Open DevTools > Shader Editor 4. Click "Reload" button 5. Check "Toggle geometry visibility" icon Actual results: Toggle geometry visibility icon is gone, because itemToggle.png was already replaced to itemToggle.svg in Bug 1260523. Regression range: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=a097b61f58102776941bd3fa0023092ac3f27a3f&tochange=006a4f4e68522332a36fd7eccd9664b73efae975 Expected results: Fix itemToggle icon url in shadereditor.css
Blocks: 1260523
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox50: --- → affected
status-firefox51: --- → affected
Component: Untriaged → Developer Tools: WebGL Shader Editor
OS: Unspecified → All
Hardware: Unspecified → All
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
MozReview-Commit-ID: 6LZfdklnm0o
MozReview-Commit-ID: 6LZfdklnm0o
Attachment #8785128 - Attachment is obsolete: true
Comment on attachment 8785129 [details] [diff] [review] Fix erronous references to itemToggle.png opacity: 0.3 is consistent with what we do in the styleeditor
Attachment #8785129 - Flags: review?(bgrinstead)
Attachment #8785129 - Flags: review?(bgrinstead) → review+
Keywords: checkin-needed
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/fx-team/rev/5cefc6af9611 Fix erronous references to itemToggle.png. r=bgrins
Keywords: checkin-needed
Comment on attachment 8785129 [details] [diff] [review] Fix erronous references to itemToggle.png Approval Request Comment [Feature/regressing bug #]: bug 1260523 [User impact if declined]: broken shader editor UI (the item checkbox doesn't appear) [Describe test coverage new/current, TreeHerder]: local testing + in fx-team, soon in Nightly [Risks and why]: low, css only [String/UUID change made/needed]: no
Attachment #8785129 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/5cefc6af9611
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Hello magicp, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(magicp.jp)
Comment on attachment 8785129 [details] [diff] [review] Fix erronous references to itemToggle.png Fixes a regression, Aurora50+
Attachment #8785129 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have reproduced this bug with Firefox Nightly 51.0a1 (2016-08-21) on Windows 10, 32-bit. Verified as fixed with Latest Firefox nightly 51.0a1 (Build ID 20160830030201) User Agent :Mozilla/5.0 (Windows NT 10.0; rv:51.0) Gecko/20100101 Firefox/51.0 [bugday-20160824]
(In reply to Ritu Kothari (:ritu) from comment #8) > Hello magicp, could you please verify this issue is fixed as expected on a > latest Nightly build? Thanks! verified on a latest Nightly and Aurora. Thanks!
Status: RESOLVED → VERIFIED
status-firefox50: fixed → verified
status-firefox51: fixed → verified
Flags: needinfo?(magicp.jp)
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: