Move enabling ARM-NEON PNG support from old-configure.in to libpng/moz.build

RESOLVED FIXED in Firefox 51

Status

()

defect
--
trivial
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: glennrp+bmo, Assigned: glennrp+bmo)

Tracking

Trunk
mozilla51
ARM
Unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

3 years ago
In bug #127627 comment #30, Jeff suggested that the detection of ARM-NEON support in PNG should be done in libpng/moz.build.
Assignee

Updated

3 years ago
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
Depends on: 832390
Assignee

Updated

3 years ago
Depends on: 1276127
No longer depends on: 832390
Assignee

Comment 1

3 years ago
Typo: In bug #1276127 comment #30, Jeff suggested....
Assignee

Updated

3 years ago
Summary: Drop ARM-NEON selection from old-configure.in; do it in libpng/moz.build instead → Move enabling ARM-NEON PNG support from old-configure.in to libpng/moz.build
Assignee

Comment 2

3 years ago
Moves PNG ARM-NEON selection from old-configure.in to media/libpng/moz.build.  Try?
Flags: needinfo?(ryanvm)
The patch fails to apply due to the hunk from old.configure (which doesn't exist in a clean tree). I've removed it locally for now, but please attach a new patch that doesn't include it before requesting review.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b8605de8c49
Flags: needinfo?(ryanvm)
Assignee

Comment 4

3 years ago
Fixed offset in old-configure
Assignee

Updated

3 years ago
Attachment #8784597 - Flags: review?(jmuizelaar)
Assignee

Updated

3 years ago
Attachment #8783324 - Attachment is obsolete: true
Assignee

Comment 5

3 years ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> The patch fails to apply due to the hunk from old.configure (which doesn't
> exist in a clean tree).

The hunk exists but the offset was wrong by one; I fixed that in the v01 patch.
Attachment #8784597 - Flags: review?(jmuizelaar) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab552be6e7e7
Move enabling ARM-NEON PNG from old-configure.in to libpng/moz.build. r=jrmuizel
Keywords: checkin-needed
Assignee

Comment 7

3 years ago
Fixed fresh bit-rot
Assignee

Comment 8

3 years ago
Tye v01 patch won't work due to another recent checkin of old-configure.in, etc.  Please checkin the v02 patch instead.
Flags: needinfo?(ryanvm)
Comment on attachment 8784597 [details] [diff] [review]
v01-1296946-drop-ARM-selection-from-old-configure

I already took care of that (and fixed the incorrect bug number in the commit message) when landing it yesterday.
Attachment #8784597 - Attachment is obsolete: true
Flags: needinfo?(ryanvm)

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ab552be6e7e7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.