1296977 - Add 'Inspect in DOM panel' context menu entry to Inspector

Status: NEW

(DevTools :: Inspector, enhancement, P3)

Description

[Kostas]

Using FF 48 x64 (and Nightly 51 x64) in win 10 x64.

After the implementation of the DOM panel in FF48 (bug 1201475),
I'd like to make a suggestion, please:
to add 'Inspect in DOM panel' context menu entry to Inspector

For reference:
- Firebug provides: HTML tab|right click an element|'Inspect in DOM panel', and 
- DOM Inspector (the extension) provides:           (https://goo.gl/cDkVxz)
  (1) Edit|'Select Element by Click'|click an element in Inspector, and: 
  (2) a select-by-click toolbar button|click an element on the page.

Comment 1

[Patrick Brosset <:pbro>]

We might want to do this only for people who have activated the DOM panel, just a thought.

We also need to take into consideration that we recently removed a few items from the menu and re-organized others, in an effort to make it easier to understand, and shorter.
So adding yet another item might be a problem.

We also have the "Show Dom Properties" in the menu already, so it could be a bit of a duplicate. Maybe we could replace that option with "show in DOM panel", or something.

Finally, as far as I know, the DOM panel doesn't support showing properties for any object, it only shows the properties of the global object. So there might be some dev needed there too.

Pinging Helen and Honza to get their points of view on this.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Patrick Brosset <:pbro> from comment #1)
> We might want to do this only for people who have activated the DOM panel,
> just a thought.
That makes sense.

I think that the trend is rather using side-DOM panel that could be utilized in several panels: 
- Console (aka VariablesView)
- Debugger (Watch panel)
- Inspector (DOM properties)

> We also have the "Show Dom Properties" in the menu already, so it could be a
> bit of a duplicate. Maybe we could replace that option with "show in DOM
> panel", or something.

Note that Firebug's concept of "inspect" menu-items wasn't only related to the DOM panel. It was rather an aspect of "reps" (templates for data rendering). Rep object could implement an `inspect` method that automatically selects the right panel for inspection (e.g. Inspector panel for elements, DOM panel for JS objects, Debugger for functions, Net for XHRs etc.). The context menu was generated according to what reps has been clicked by the user and if the clicked reps implements the 'inspect' method.

We might get some inspiration from the concept (e.g. 'Show in DOM panel' is essentially the same as 'Inspect in DOM panel'.


> Finally, as far as I know, the DOM panel doesn't support showing properties
> for any object, it only shows the properties of the global object. So there
> might be some dev needed there too.
Correct

Honza

Comment 3

[Patrick Brosset <:pbro>]

Thanks Honza. Setting P3 since it's a new feature we're not likely to work on soon.