Closed
Bug 1296990
Opened 8 years ago
Closed 8 years ago
Make AppearanceString() return nsAutoString directly
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(1 file)
I cannot remember why we return nsString. The appearance string is already nsAutoString, and is short enough. No need to return a nsString. [1] http://searchfox.org/mozilla-central/source/layout/base/AccessibleCaret.cpp#144
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8783388 [details] Bug 1296990 - Make AppearanceString() return nsAutoString directly. https://reviewboard.mozilla.org/r/73190/#review70956
Attachment #8783388 -
Flags: review?(mtseng) → review+
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfd76b4f5f77 Make AppearanceString() return nsAutoString directly. r=mtseng
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dfd76b4f5f77
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•