Make AppearanceString() return nsAutoString directly

RESOLVED FIXED in Firefox 51

Status

()

Core
Selection
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

Trunk
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

I cannot remember why we return nsString. The appearance string is already nsAutoString, and is short enough. No need to return a nsString.

[1] http://searchfox.org/mozilla-central/source/layout/base/AccessibleCaret.cpp#144
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8783388 [details]
Bug 1296990 - Make AppearanceString() return nsAutoString directly.

https://reviewboard.mozilla.org/r/73190/#review70956
Attachment #8783388 - Flags: review?(mtseng) → review+

Comment 3

2 years ago
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfd76b4f5f77
Make AppearanceString() return nsAutoString directly. r=mtseng

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dfd76b4f5f77
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.