1296996 - Return of crash in mozilla::gl::SharedSurface_EGLImage::ProducerReleaseImpl: "MOZ_RELEASE_ASSERT(false) (GFX: Non-recycleable should not Fence twice.)"

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

Bug 1238541 fixed the previous incarnation of this about 7 months ago, but it's just spiked again, e.g.: https://crash-stats.mozilla.com/report/index/7b505988-d473-49f5-a6b1-099f92160821.

The first Nightly affected is 20160819080504. There have been 56 crashes since then, making it the #1 Fennec topcrash for the past 7 days.

jgilbert, you fixed the previous bug -- any ideas what might have happened? Thanks.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Jeff, did you expect this to be fixed now with bug 1285692? I still see reports as of today's Nightly.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

This is WebVR related?

Comment 3

[u279076]

Crashes by build ID:
> 20160824030337 	7 	4.86 %
> 20160823072522 	2 	1.39 %
> 20160823030224 	2 	1.39 %
> 20160822064441 	12 	8.33 %
> 20160821030226 	69 	47.92 %
> 20160820030224 	34 	23.61 %
> 20160819080504 	14 	9.72 %

Comment 4

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Got a consistent repro for this. Running mozregression yields:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e7bc8b475703876a404ffb4b644cc8a2e0879898&tochange=7e665764ca147c5faaada000a08ef4329873a106

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Thanks Edwin - can you look for the fix as well?

Comment 6

[Robert Kaiser]

This seems to happen on many Android devices, but FWIW, I can reproduce with recent Nightlies on my Nexus 10 by loading https://lantea.kairo.at/ (which uses WebGL).

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Oh actually given the regression range and the fact that jgilbert made this depend on bug 1285692 (which is *in* the regression range), I assume he meant to make this bug *block* bug 1285692 as the source of the regression.

Comment 8

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: 1296996.patch

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee1070c230bd
Use ProducerRead{Acquire/Release} in ReadBuffer::Create - r=jgilbert

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ee1070c230bd